This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Repository navigation
Fix bug to check parent file when meta is checked - #924
Merged
Merged
Conversation
StanleyGoldman
requested review from
annthurium,
daviwil,
drguthals,
grokys,
jcansdale,
queerviolet and
smashwilson
October 3, 2018 20:37
queerviolet
suggested changes
Oct 4, 2018
queerviolet
left a comment
There was a problem hiding this comment.
Looks good!
I think the multilevel test is would be nice, but if you think it'll be too much of a pain / not worth it, it is definitely not a hill I will die on or ask you to die upon.
Contributor
Author
|
@queerviolet 🏆. That was a good call. You made me find two bugs. |
queerviolet
suggested changes
Oct 5, 2018
queerviolet
left a comment
There was a problem hiding this comment.
Yay! I have one more test request, then this looks good to go. 🙏
queerviolet
approved these changes
Oct 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #913
As a result of an item having it's check state changed in our tree lists, the check state of it's parents or children might need to be changed.
When performing this action from
TreeBase<TNode, TData>we need to be sure to callAddCheckedNode(...)orRemoveCheckedNode(...)when those items are not folders. Those functions are overloaded and allow derived classes to set some additional state.In order to do this cleanly, all nodes check states are now being changed through a central overloaded method.
Unity/src/GitHub.Api/UI/TreeBase.cs
Lines 303 to 328 in d8d92c9