This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Repository navigation
Spool files in GitClient.Remove() method to prevent possible issues - #905
Merged
Merged
Conversation
…hen trying to remove lots of files;
StanleyGoldman
approved these changes
Sep 4, 2018
Contributor
|
Thanks @KonH for picking up that spare for us. 🎖 I appreciate it. Can I ask a question? |
Contributor
Author
|
Docs are clear and understandable, I didn't have problems with them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Spool files in GitClient.Remove() method to prevent possible issues when trying to remove lots of files (similar to other methods logics).
Alternate Designs
No other alternatives (except no changes in code).
Benefits
More efficient delete of large count of files.
Possible Drawbacks
Don't know about it, looks like suitable change similar to other methods.
Applicable Issues
Relates and described here - #887