This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Repository navigation
Add support for the 4.6 profile side by side with 3.5 in 2018.x - #889
Merged
Merged
Conversation
Member
Author
|
A build of this branch is at https://github.com/github-for-unity/Unity/releases/tag/v1.0.3-beta1 for testing |
| } | ||
| if (importer.GetCompatibleWithEditor() != enable) | ||
| { | ||
| importer.SetCompatibleWithEditor(enable); |
StanleyGoldman
approved these changes
Aug 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #824
This PR adds support for the .net 4.6 profile by switching between the 3.5 and 4.5 versions of the DLLs and disabling importing of any dlls that are not needed for the target. This means that the System.Threading/AsyncBridge/ReadonlyCollections dlls we ship will only be loaded when running on the 3.5 profile.
GitHub.Api.45.csproj and GitHub.Unity.45.csproj are almost-exact copies of their original counterparts (just with the target framework and dll name changed, and irrelevant dependencies dropped).