Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Fixing PublishView to support long error messages - #361

Merged
shana merged 15 commits into
masterfrom
fixes/long-publish-error-message
Oct 23, 2017
Merged

shana merged 15 commits into
masterfrom
fixes/long-publish-error-message

Conversation

@StanleyGoldman

@StanleyGoldman StanleyGoldman commented Oct 13, 2017 •

Copy link
Copy Markdown
Contributor

Fixes #199

Trying to fix this problem
img

I did this...
img

Making the window bigger and putting the error message below the button.

private const string DescriptionLabel = "Description";
private const string CreatePrivateRepositoryLabel = "Create as a private repository";
private const string CreatePrivateRepositoryLabel = "Make repository private";
private const string PublishLimtPrivateRepositoriesError = "You are currently at your limt of private repositories";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me 👀 limt

GUILayout.EndHorizontal();

GUILayout.Space(Styles.PublishViewSpacingHeight);
GUILayout.Label("Publish to GitHub", EditorStyles.boldLabel);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string should be in a const

@shana shana left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some string adjustments needed

@shana
shana merged commit c14fb8d into master Oct 23, 2017
@shana
shana deleted the fixes/long-publish-error-message branch October 23, 2017 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish window needs to handle long api error messages better

3 participants