This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Repository navigation
Fixes to keep the publish view from loading twice - #299
Merged
Merged
Conversation
StanleyGoldman
force-pushed
the
fixes/publish-view-loading
branch
from
September 11, 2017 20:14
aad063a to
70bdbd6
Compare
4 tasks done
shana
suggested changes
Sep 12, 2017
| if (activeViewType != value) | ||
| { | ||
| ActiveView.OnDisable(); | ||
|
|
Member
There was a problem hiding this comment.
Let's not have all this wasted vertical space, I don't have that much space on my laptop (i.e. totally redundant empty line)
|
|
||
| case PopupViewType.AuthenticationView: | ||
| return authenticationView; | ||
|
|
Member
There was a problem hiding this comment.
Formatting change that doesn't need to be here
| { | ||
| case PopupViewType.PublishView: | ||
| return publishView; | ||
|
|
Member
There was a problem hiding this comment.
Formatting change that doesn't need to be here
| public static PopupWindow Open(PopupViewType popupViewType, Action<bool> onClose = null) | ||
| { | ||
| var popupWindow = GetWindow<PopupWindow>(true); | ||
|
|
Member
There was a problem hiding this comment.
Formatting change that doesn't need to be here
| public override void OnEnable() | ||
| { | ||
| base.OnEnable(); | ||
|
|
| if (GUILayout.Button(PublishViewCreateButton)) | ||
| { | ||
| GUI.FocusControl(null); | ||
|
|
StanleyGoldman
force-pushed
the
fixes/publish-view-loading
branch
3 times, most recently
from
September 12, 2017 20:06
e87ed67 to
80a81f7
Compare
StanleyGoldman
force-pushed
the
fixes/publish-view-loading
branch
from
September 12, 2017 20:08
80a81f7 to
f1b5d7e
Compare
shana
approved these changes
Sep 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current way
PopulateViewis being called causes two concurrent calls toLoadKeychain.