This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Repository navigation
Keeping the authentication if the username doesn't match in the keychain - #298
Merged
Merged
Conversation
4 tasks done
shana
approved these changes
Sep 12, 2017
shana
left a comment
shana
left a comment
Member
There was a problem hiding this comment.
Looks good, just wondering why the spurious logging change
shana
approved these changes
Sep 12, 2017
shana
left a comment
shana
left a comment
Member
There was a problem hiding this comment.
LGTM except for that totally unrelated formatting change 👀
| var cachedConnection = connectionCache[host]; | ||
|
|
||
| logger.Trace($@"Loading KeychainAdapter Host:""{host}"" Cached Username:""{cachedConnection.Username}"""); | ||
| logger.Trace("Loading KeychainAdapter Host:\"{0}\" Cached Username:\"{1}\"", host, cachedConnection.Username); |
Member
There was a problem hiding this comment.
Formatting change that doesn't need to be here
StanleyGoldman
force-pushed
the
fixes/kepp-auth-if-user-does-not-match
branch
from
September 12, 2017 20:11
d3accd9 to
5c07e42
Compare
shana
approved these changes
Sep 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177
Depends on: