This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Repository navigation
File history revert - #1009
Merged
StanleyGoldman merged 2 commits intoFeb 12, 2019
Merged
File history revert#1009StanleyGoldman merged 2 commits into
StanleyGoldman merged 2 commits into
Conversation
Contributor
|
Thanks @sambonfire I got some changes to what you did here but it's looking good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
The main change is that this allows you to revert an individual file to a specific point in time.
This PR also has some changes in it that allow the UI to survive domain reloads (previously, the title and icon would disappear but the history view would persist).
Alternate Designs
Many ways to do this; happy to make changes if I'm breaking any sorts of conventions.
Benefits
Users are prompted if the file they are reverting is changed locally (so it's safe). Perhaps an even better fix would be to move the existing file into the recycle bin so they could restore it if necessary? This also allows the UI to survive domain reloads
Possible Drawbacks
I don't see much use of the GitClient in the UI layer so I'm not sure if I'm violating some convention..
Applicable Issues
none