Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

After a certain number of changes, no changes are displayed locally #899

Closed
Closed
After a certain number of changes, no changes are displayed locally#899
Assignees
StanleyGoldman
Labels
bugduplicate

Description

@shafy
shafy
opened on Aug 27, 2018

Description

After adding a couple of hundred files (importing assets), the changes just stop showing up completely (also the previously shown changed files are now gone from the "Changes" tab).

This is logged if I add a new empty script:

180827-15:20:48.937 TRACE [ 1] <GitLocksCache>                     needsInvalidation isInitialized:True timedOut:True
180827-15:20:48.938 TRACE [181] <ProcessWrapper>                    Running '/usr/bin/git -c i18n.logoutputencoding=utf8 -c core.quotepath=false status -b -u --porcelain'
180827-15:20:48.948 TRACE [182] <ProcessWrapper>                    Running '/usr/local/bin/git-lfs locks --json'

Steps to Reproduce

  1. Open a new project
  2. Install GitHub plugin
  3. Publish repo
  4. Import hundreds of asset files
  5. "Changes" tab starts showing changed files
  6. Import more files
  7. "Changes" tab suddenly stops showing any changes at all (also older changed files are gone)

Expected behavior: Show all changed files.

Actual behavior: Shows 0 changed files.

Reproduces how often: 100%

Activity

  1. StanleyGoldman commented on Aug 28, 2018

    @StanleyGoldman
    StanleyGoldman
    on Aug 28, 2018
    Contributor

    Hey @shafy Thanks for testing our stuff out.

    You don't happen to have a public repo I could clone to try to reproduce this error would you?
    I tried a while back stress testing this thing with changes. I got pretty high without showing trouble...

    Would you happen to have a closer count on how many? Also what types of files?
    Maybe you can look at your commit history and let me know..

  2. StanleyGoldman
    added
    more-information-needed
    bug
    on Aug 28, 2018

  3. shafy commented on Aug 28, 2018

    @shafy
    shafy
    on Aug 28, 2018
    Author

    Here, I made the repo public. It's a random test anyways :-) https://github.com/shafy/unity-kosmos-test-6

    If you clone this project and add the GitHub plugin in Unity, adding more files doesn't show the changed files.

    Regarding your questions:

    • It was a whole folder, so I don't know which file type
    • Ended up not committing and created a new repo through git command line

  4. StanleyGoldman commented on Sep 17, 2018

    @StanleyGoldman
    StanleyGoldman
    on Sep 17, 2018
    Contributor

    Hey @shafy Thanks for putting that together. I'm gonna try to test it out now.

  5. StanleyGoldman commented on Sep 17, 2018

    @StanleyGoldman
    StanleyGoldman
    on Sep 17, 2018
    Contributor

    You never mentioned what OS you are using? or what version of Unity this was with?

  6. StanleyGoldman commented on Sep 17, 2018

    @StanleyGoldman
    StanleyGoldman
    on Sep 17, 2018
    Contributor

    So I'm testing your project with Unity 2018.2 and GitHub for Unity 1.0.3.
    I'm able to make changes, but so far I'm unable to view the history of your project. I'm still looking into it.

  7. StanleyGoldman
    self-assigned this
    on Sep 17, 2018

  8. shafy commented on Sep 18, 2018

    @shafy
    shafy
    on Sep 18, 2018
    Author

    Cool. I used GitHub for Unity 1.0.2, Unity 2018.2.6f1 (right now I'm using this, not sure if I upgraded in the meantime to be honest) and macOS High Sierra 10.13.6

  9. StanleyGoldman commented on Oct 3, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 3, 2018
    Contributor

    Okay, so there is a caching issue that I'm looking to debug, but your repo pointed me to a different issue.

    https://github.com/shafy/unity-kosmos-test-6/commit/9d11c855260edbc19f9c51ab374c2f795d318b0c

    This commit right here deletes a file named c:UsersOculusGoVideo.mp4 which completely throws off my ability to read your log.

  10. StanleyGoldman commented on Oct 3, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 3, 2018
    Contributor

    Okay, that's solved, now to figure out this caching issue for good.

  11. StanleyGoldman commented on Oct 3, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 3, 2018
    Contributor

    hey @shafy

    I believe you are all "stuck" in a state where your cache has invalidated, it tried once to validate it, and it no longer attempts to validate. So your logs show up empty.

    I think I have gotten closer to solve the issue, but I need your help in testing this next build.

    https://ci.appveyor.com/api/buildjobs/ehbdp9cf383c4lj7/artifacts/github-for-unity-1.1.0.6098.unitypackage

    This build contains the fix from #921 and #923. I think this will help us find what your next problem is.

  12. StanleyGoldman
    removed
    more-information-needed
    on Oct 3, 2018

  13. StanleyGoldman commented on Oct 4, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 4, 2018
    Contributor

    My build server screwed me and that previous link won't install correctly. Unzip and try this instead.

    github-for-unity-1.1.0.4987-360a4850.unitypackage.zip

  14. StanleyGoldman commented on Oct 5, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 5, 2018
    Contributor

    🐑 👋 I know we've taken a long time to figure this one out, but I'd like to get it figured out for the next release. 😅 @shafy

  15. shafy commented on Oct 5, 2018

    @shafy
    shafy
    on Oct 5, 2018
    Author

    hey @StanleyGoldman not sure what I'm missing but I can't install the package. How do I need to do it?

  16. StanleyGoldman commented on Oct 5, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 5, 2018
    Contributor

    Unzip the file first..

  17. StanleyGoldman commented on Oct 5, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 5, 2018
    Contributor

    Dunno if you noticed that

  18. shafy commented on Oct 5, 2018

    @shafy
    shafy
    on Oct 5, 2018
    Author

    Yeah I did. And the there are a bunch of folders and Unity doesn't let me import them as packages.

  19. StanleyGoldman commented on Oct 5, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 5, 2018
    Contributor

    Are you on discord? would you like to do a video call?

  20. shafy commented on Oct 5, 2018

    @shafy
    shafy
    on Oct 5, 2018
    Author

    Yeah my tag is shafy#6778

  21. StanleyGoldman commented on Oct 5, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 5, 2018
    Contributor

    Sent you an invite, otherwise find me here.. https://discord.gg/dnxD4CV

  22. StanleyGoldman commented on Oct 8, 2018

    @StanleyGoldman
    StanleyGoldman
    on Oct 8, 2018
    Contributor

    I'm finally able to reproduce this, I'm sure this is a duplicate of #871

  23. StanleyGoldman
    added
    duplicate
    on Oct 8, 2018
  24. StanleyGoldman
    closed this as completedon Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugduplicate

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions