Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Not show "Release Lock" in Menu Item #851

Closed
Closed
Not show "Release Lock" in Menu Item#851
Labels
bug

Description

@ghost
ghost
opened on Jun 29, 2018

Description

Not show "Release Lock" in Menu Item
2018-06-29_17h07_29

Steps to Reproduce

  1. Lock any file
  2. Right click locked file

Reproduces how often: Always

Additional Information

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs

Line 122 in 41ae437

[MenuItem(AssetsMenuReleaseLockForced, false, 10001)]

This line should be AssetsMenuReleaseLock here instead of AssetsMenuReleaseLockForced, shouldn't it?

Activity

  1. StanleyGoldman commented on Jun 29, 2018

    @StanleyGoldman
    StanleyGoldman
    on Jun 29, 2018
    Contributor

    🥇 LOL thanks @ykush.
    Would you want to make that change in a pull request so you can get the credit?

  2. StanleyGoldman
    added
    bug
    on Jun 29, 2018

  4. StanleyGoldman commented on Jun 30, 2018

    @StanleyGoldman
    StanleyGoldman
    on Jun 30, 2018
    Contributor

    Hey @ykush I don't think the failure is your fault. We have bugs in the build server that prevent it from building successfully for other users.

  5. StanleyGoldman commented on Jul 2, 2018

    @StanleyGoldman
    StanleyGoldman
    on Jul 2, 2018
    Contributor

    Fixed by #852 thanks @ykush

  6. StanleyGoldman
    closed this as completedon Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions