Add integration tests for server block ops and USERDATA handlers#644
Merged
gijzelaerr merged 1 commit intomasterfrom Mar 20, 2026
Merged
Add integration tests for server block ops and USERDATA handlers#644gijzelaerr merged 1 commit intomasterfrom
gijzelaerr merged 1 commit intomasterfrom
Conversation
Adds 32 new tests exercising server-side protocol handlers through real client-server communication: block list/info/upload/download, SZL reads, clock get/set, PLC control (stop/start/compress), and error scenarios for unregistered areas and nonexistent blocks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_server_coverage.pyexercising server-side protocol handlers through real client-server communicationsnap7/server/__init__.pystatement coverage from 74% to 75% (9 additional lines covered; remaining gaps are mainloop, ServerISOConnection thread internals, and network error branches)Test plan
uv run pytest tests/test_server_coverage.py -vuv run pytest tests/ --ignore=tests/test_s7commplus_e2e.py -quv run ruff check tests/test_server_coverage.py && uv run ruff format --check tests/test_server_coverage.py🤖 Generated with Claude Code