Add PROFINET DCP network discovery#634
Merged
Merged
Conversation
10 tasks
Wraps pnio-dcp library for discovering Siemens PLCs on the local network. Includes Device dataclass, discover() and identify() functions, and CLI entry point. Closes #622 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Exports a reusable click command (discover_command) that the s7 CLI can auto-register as `s7 discover`. Removes the standalone snap7-scan entry point in favor of the unified s7 CLI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gijzelaerr
force-pushed
the
feature/discovery
branch
from
d0eae0b to
75df40b
Compare
- Resolve merge conflicts with master (uv.lock) - Remove standalone snap7-scan entry point; discover is now a subcommand of the existing s7 CLI (s7 discover) - Add CLI documentation for all s7 subcommands (doc/cli.rst) - Add discovery API reference (doc/API/discovery.rst) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Devicefrozen dataclass with name, IP, MAC, netmask, gateway, familydiscover()andidentify()library functions insnap7.discoverys7 discoversubcommand of the existing CLI (no separate entry point)discoveryoptional dependency group (pip install python-snap7[discovery])s7subcommands (doc/cli.rst)doc/API/discovery.rst)Closes #622
Test plan
tests/test_discovery.py)🤖 Generated with Claude Code