Fix #671: updatekeys checks for config file flag#672
Merged
autrilla merged 5 commits intogetsops:developfrom May 8, 2020
Merged
Fix #671: updatekeys checks for config file flag#672autrilla merged 5 commits intogetsops:developfrom
updatekeys checks for config file flag#672autrilla merged 5 commits intogetsops:developfrom
Conversation
added 4 commits
May 7, 2020 21:48
The 'updatekeys' subcommand did not check for the config flag in the command line. Add that check and if found use it to set configPath.
The 'updatekeys' subcommand did not check for the config global string flag. Add that check and if found use it to set configPath.
The 'updatekeys' subcommand did not check for the config global string flag. Add that check and if found use it to set configPath. Edit: Remove mistake file addition
Codecov Report
@@ Coverage Diff @@
## develop #672 +/- ##
========================================
Coverage 38.23% 38.23%
========================================
Files 23 23
Lines 3329 3329
========================================
Hits 1273 1273
Misses 1927 1927
Partials 129 129 Continue to review full report at Codecov.
|
autrilla
approved these changes
May 8, 2020
Contributor
autrilla
left a comment
autrilla
left a comment
There was a problem hiding this comment.
LGTM, thanks!
We should probably clean up the flags at some point though...
ajvb
approved these changes
May 8, 2020
rochaporto
pushed a commit
to rochaporto/sops
that referenced
this pull request
Jun 22, 2020
* update 'updatekeys' subcommand to use config (if exists) from commandline * Fix getsops#671: `updatekeys` checks for config file flag The 'updatekeys' subcommand did not check for the config flag in the command line. Add that check and if found use it to set configPath. * Fix getsops#671: `updatekeys` checks for config file flag The 'updatekeys' subcommand did not check for the config global string flag. Add that check and if found use it to set configPath. * Fix getsops#671: `updatekeys` checks for config file flag The 'updatekeys' subcommand did not check for the config global string flag. Add that check and if found use it to set configPath. Edit: Remove mistake file addition * Update cmd/sops/main.go Co-authored-by: Adrian Utrilla <adrianutrilla@gmail.com>
This was referenced Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'updatekeys' subcommand did not check for the config global string flag.
Add that check and if found use it to set configPath.