build(test-threading-logger): Migrate from pip to uv#53
Merged
Conversation
Replace requirements.txt with pyproject.toml and update run.sh to use uv for dependency management and script execution. Refs PY-2480 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment on lines
+4
to
+8
| if ! command -v uv &> /dev/null; then | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| fi | ||
|
|
||
| python main.py No newline at end of file | ||
| uv run python main.py |
There was a problem hiding this comment.
Bug: The script installs uv but doesn't update the current shell's $PATH. The subsequent call to uv fails because the command cannot be found, causing the script to exit.
Severity: MEDIUM
Suggested Fix
After installing uv, source the relevant shell configuration file (e.g., source ~/.bashrc) or find the uv binary and call it using its absolute path (e.g., ~/.cargo/bin/uv run ...) to ensure it's available in the current script's environment.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: test-threading-logger/run.sh#L4-L8
Potential issue: The `run.sh` script attempts to install the `uv` tool if it's not
present. The installer adds the `uv` binary's location to the `$PATH` by modifying shell
configuration files (e.g., `~/.bashrc`). However, these changes are not sourced by the
currently running script. Consequently, when the script immediately calls `uv run python
main.py`, the shell cannot find the `uv` command because its `$PATH` is not updated.
Since the script uses `set -euo pipefail`, this 'command not found' error causes the
script to exit prematurely on its first run on a clean system.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requirements.txtwithpyproject.tomlfor dependency managementrun.shto useuv runinstead of manual venv/pip workflowTest plan
./run.shand verify the app runs correctly🤖 Generated with Claude Code