build(test-overhaul-of-docs): Migrate to uv and pyproject.toml#40
Conversation
Replace pip/requirements.txt with uv/pyproject.toml for dependency management. Update run.sh to use uv run. Refs PY-2467 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| if ! command -v uv &> /dev/null; then | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| fi | ||
|
|
||
| # create and activate virtual environment | ||
| python -m venv .venv | ||
| source .venv/bin/activate | ||
|
|
||
| # Install (or update) requirements | ||
| python -m pip install -r requirements.txt | ||
|
|
||
|
|
||
| # uvicorn main:app --port 8000 | ||
| # gunicorn main:app | ||
| python main.py | ||
| # sanic main:app | ||
| # flask --app main run | ||
|
|
||
| # echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
| # echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
| # echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
|
|
||
| # arq demo.WorkerSettings No newline at end of file | ||
| uv run python main.py |
There was a problem hiding this comment.
Bug: The script installs uv but fails to update the current shell's PATH, causing the subsequent uv command to fail on systems where it wasn't pre-installed.
Severity: HIGH
Suggested Fix
After the uv installation command, source the appropriate environment file to update the PATH for the current session (e.g., source "$HOME/.cargo/env"). Alternatively, invoke uv using its full installation path, such as $HOME/.cargo/bin/uv.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: test-overhaul-of-docs/run.sh#L4-L8
Potential issue: The `run.sh` script attempts to install `uv` if it is not found.
However, the installer (`curl -LsSf https://astral.sh/uv/install.sh | sh`) only updates
shell configuration files like `.bashrc` and does not modify the `PATH` of the currently
running script session. Consequently, the subsequent command `uv run python main.py`
fails with a "command not found" error. Because the script uses `set -euo pipefail`,
this error will cause the script to terminate immediately on any clean environment, such
as a CI runner or a new developer setup, that does not have `uv` pre-installed.
Did we get this right? 👍 / 👎 to inform future reviews.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 440d644. Configure here.
| # echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" | ||
|
|
||
| # arq demo.WorkerSettings No newline at end of file | ||
| uv run python main.py |
There was a problem hiding this comment.
uv not on PATH after install
Medium Severity
When uv is missing, run.sh installs it via curl | sh, but the installer runs in a subshell and does not update PATH in the current script. The next uv run line often fails with “command not found” on a first run without uv already installed.
Reviewed by Cursor Bugbot for commit 440d644. Configure here.
1 participant
Summary
pip/requirements.txtwithuv/pyproject.tomlfor dependency managementrun.shto useuv runrequirements.txtRefs PY-2467
🤖 Generated with Claude Code