ref(workflow_engine): Cleanup some of our code by saponifi3d · Pull Request #112246 · getsentry/sentry

saponifi3d · 2026-04-03T23:30:10Z

Description

Move the ensure_default_detector code out of the file for process_detectors and into defaults/detectors.py
Move the signals from the global folder to workflow_engine module for discoverability

There shouldn't be any logic changes to this code, it's just a simple move from one file to another (this is setting up a few more PRs)

github-actions · 2026-04-03T23:47:50Z

Backend Test Failures

Failures on e3f6223 in this run:

tests/sentry/backup/test_exhaustive.py::ExhaustiveTests::test_exhaustive_dirty_pks — log

tests/sentry/backup/test_exhaustive.py:37: in test_exhaustive_dirty_pks
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_exhaustive.py::ExhaustiveTests::test_uniqueness — log

tests/sentry/backup/test_exhaustive.py:43: in test_uniqueness
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_exports.py::ScopingTests::test_config_export_scoping — log

tests/sentry/backup/test_exports.py:318: in test_config_export_scoping
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_exports.py::ScopingTests::test_global_export_scoping — log

tests/sentry/backup/test_exports.py:388: in test_global_export_scoping
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_exports.py::ScopingTests::test_organization_export_scoping — log

tests/sentry/backup/test_exports.py:252: in test_organization_export_scoping
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_exports.py::ScopingTests::test_user_export_scoping — log

tests/sentry/backup/test_exports.py:188: in test_user_export_scoping
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_exports.py::FilteringTests::test_export_filter_orgs_empty — log

tests/sentry/backup/test_exports.py:722: in test_export_filter_orgs_empty
    org_a = self.create_exhaustive_organization("org-a", a, a_b, [a_b_c])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_exports.py::FilteringTests::test_export_filter_orgs_multiple — log

tests/sentry/backup/test_exports.py:630: in test_export_filter_orgs_multiple
    org_a = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_exports.py::FilteringTests::test_export_filter_orgs_single — log

tests/sentry/backup/test_exports.py:544: in test_export_filter_orgs_single
    org_a = self.create_exhaustive_organization("org-a", a, a_b, [a_b_c])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::SanitizationTests::test_org_and_project_option_type_preserve — log

tests/sentry/backup/test_imports.py:690: in test_org_and_project_option_type_preserve
    import_in_organization_scope(tmp_file, printer=NOOP_PRINTER)
src/sentry/backup/imports.py:611: in import_in_organization_scope
    return _import(
src/sentry/backup/imports.py:544: in _import
    do_writes(pk_map)
src/sentry/backup/imports.py:473: in do_writes
    do_write(import_write_context, pk_map, model_name, json_data, offset)
src/sentry/backup/imports.py:406: in do_write
    raise ImportingError(result)
E   sentry.backup.imports.ImportingError: is_err=True kind='Unknown' on=InstanceID(model='sentry.project', ordinal=None) left_pk=None right_pk=None reason='Unknown internal error occurred: Traceback (most recent call last):\n  File "/home/runner/work/sentry/sentry/src/sentry/backup/services/import_export/impl.py", line 263, in import_by_model\n    written = model_instance.write_relocation_import(\n        import_scope, import_flags\n    )\n  File "/home/runner/work/sentry/sentry/src/sentry/models/project.py", line 884, in write_relocation_import\n    from sentry.receivers.project_detectors import disable_default_detector_creation\nModuleNotFoundError: No module named \'sentry.receivers.project_detectors\'\n'

tests/sentry/backup/test_imports.py::SignalingTests::test_import_signaling_organization — log

tests/sentry/backup/test_imports.py:731: in test_import_signaling_organization
    self.create_exhaustive_organization("some-org", owner, invited, [member])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::SignalingTests::test_import_signaling_organization_with_control_provisioning_option — log

tests/sentry/backup/test_imports.py:768: in test_import_signaling_organization_with_control_provisioning_option
    self.test_import_signaling_organization()
tests/sentry/backup/test_imports.py:731: in test_import_signaling_organization
    self.create_exhaustive_organization("some-org", owner, invited, [member])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::ScopingTests::test_config_import_scoping — log

tests/sentry/backup/test_imports.py:859: in test_config_import_scoping
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::ScopingTests::test_global_import_scoping — log

tests/sentry/backup/test_imports.py:879: in test_global_import_scoping
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::ScopingTests::test_organization_import_scoping — log

tests/sentry/backup/test_imports.py:839: in test_organization_import_scoping
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::ScopingTests::test_user_import_scoping — log

tests/sentry/backup/test_imports.py:824: in test_user_import_scoping
    self.create_exhaustive_instance(is_superadmin=True)
src/sentry/testutils/helpers/backups.py:953: in create_exhaustive_instance
    org = self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::DatabaseResetTests::test_persist_existing_models_in_config_scope — log

tests/sentry/backup/test_imports.py:960: in test_persist_existing_models_in_config_scope
    self.create_exhaustive_organization("neworg", owner, user, None)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::DatabaseResetTests::test_persist_existing_models_in_organization_scope — log

tests/sentry/backup/test_imports.py:972: in test_persist_existing_models_in_organization_scope
    self.create_exhaustive_organization("neworg", owner, user, None)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::DatabaseResetTests::test_persist_existing_models_in_user_scope — log

tests/sentry/backup/test_imports.py:948: in test_persist_existing_models_in_user_scope
    self.create_exhaustive_organization("neworg", owner, user, None)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::DecryptionTests::test_global_import_decryption — log

tests/sentry/backup/test_imports.py:1103: in test_global_import_decryption
    import_in_global_scope(
src/sentry/backup/imports.py:668: in import_in_global_scope
    return _import(
src/sentry/backup/imports.py:544: in _import
    do_writes(pk_map)
src/sentry/backup/imports.py:473: in do_writes
    do_write(import_write_context, pk_map, model_name, json_data, offset)
src/sentry/backup/imports.py:406: in do_write
    raise ImportingError(result)
E   sentry.backup.imports.ImportingError: is_err=True kind='Unknown' on=InstanceID(model='sentry.project', ordinal=None) left_pk=None right_pk=None reason='Unknown internal error occurred: Traceback (most recent call last):\n  File "/home/runner/work/sentry/sentry/src/sentry/backup/services/import_export/impl.py", line 263, in import_by_model\n    written = model_instance.write_relocation_import(\n        import_scope, import_flags\n    )\n  File "/home/runner/work/sentry/sentry/src/sentry/models/project.py", line 884, in write_relocation_import\n    from sentry.receivers.project_detectors import disable_default_detector_creation\nModuleNotFoundError: No module named \'sentry.receivers.project_detectors\'\n'

tests/sentry/backup/test_imports.py::DecryptionTests::test_organization_import_decryption — log

tests/sentry/backup/test_imports.py:1063: in test_organization_import_decryption
    import_in_organization_scope(
src/sentry/backup/imports.py:611: in import_in_organization_scope
    return _import(
src/sentry/backup/imports.py:544: in _import
    do_writes(pk_map)
src/sentry/backup/imports.py:473: in do_writes
    do_write(import_write_context, pk_map, model_name, json_data, offset)
src/sentry/backup/imports.py:406: in do_write
    raise ImportingError(result)
E   sentry.backup.imports.ImportingError: is_err=True kind='Unknown' on=InstanceID(model='sentry.project', ordinal=None) left_pk=None right_pk=None reason='Unknown internal error occurred: Traceback (most recent call last):\n  File "/home/runner/work/sentry/sentry/src/sentry/backup/services/import_export/impl.py", line 263, in import_by_model\n    written = model_instance.write_relocation_import(\n        import_scope, import_flags\n    )\n  File "/home/runner/work/sentry/sentry/src/sentry/models/project.py", line 884, in write_relocation_import\n    from sentry.receivers.project_detectors import disable_default_detector_creation\nModuleNotFoundError: No module named \'sentry.receivers.project_detectors\'\n'

tests/sentry/backup/test_imports.py::FilterTests::test_import_filter_orgs_empty — log

tests/sentry/backup/test_imports.py:1318: in test_import_filter_orgs_empty
    self.create_exhaustive_organization("org-a", a, a_b, [a_b_c])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::FilterTests::test_import_filter_orgs_multiple — log

tests/sentry/backup/test_imports.py:1268: in test_import_filter_orgs_multiple
    self.create_exhaustive_organization("org-a", a, a_b, [a_b_c])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::FilterTests::test_import_filter_orgs_single — log

tests/sentry/backup/test_imports.py:1226: in test_import_filter_orgs_single
    self.create_exhaustive_organization("org-a", a, a_b, [a_b_c])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::CollisionTests::test_colliding_data_source — log

tests/sentry/backup/test_imports.py:1689: in test_colliding_data_source
    self.create_exhaustive_organization("some-org", owner, invited)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::CollisionTests::test_colliding_monitor — log

tests/sentry/backup/test_imports.py:1487: in test_colliding_monitor
    self.create_exhaustive_organization("some-org", owner, invited)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::CollisionTests::test_colliding_org_auth_token — log

tests/sentry/backup/test_imports.py:1519: in test_colliding_org_auth_token
    self.create_exhaustive_organization("some-org", owner, invited, [member])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::CollisionTests::test_colliding_project_key — log

tests/sentry/backup/test_imports.py:1570: in test_colliding_project_key
    self.create_exhaustive_organization("some-org", owner, invited, [member])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::CollisionTests::test_colliding_query_subscription — log

tests/sentry/backup/test_imports.py:1612: in test_colliding_query_subscription
    self.create_exhaustive_organization("some-org", owner, invited, [member])
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

tests/sentry/backup/test_imports.py::CustomImportBehaviorTests::test_hide_organizations_import_flag — log

tests/sentry/backup/test_imports.py:2291: in test_hide_organizations_import_flag
    self.create_exhaustive_organization(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/helpers/backups.py:492: in create_exhaustive_organization
    project = self.create_project(name=f"project-{slug}", teams=[team], organization=org)
src/sentry/testutils/fixtures.py:216: in create_project
    return Factories.create_project(**kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:564: in create_project
    from sentry.receivers.project_detectors import disable_default_detector_creation
E   ModuleNotFoundError: No module named 'sentry.receivers.project_detectors'

... and 8 more failures.

src/sentry/workflow_engine/receivers/project_detectors.py

…peases the rest of the errors

github-actions · 2026-04-04T00:33:04Z

Backend Test Failures

Failures on c3a986d in this run:

tests/sentry/workflow_engine/receivers/test_project_detectors.py::TestEnsureMetricDetector::test_send_new_detector_data_failure_blocks_creation

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/receivers/test_project_detectors.py:91: in test_send_new_detector_data_failure_blocks_creation
    with mock.patch(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1495: in __enter__
    original, local = self.get_original()
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1465: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry.workflow_engine.processors.detector' from '/home/runner/work/sentry/sentry/src/sentry/workflow_engine/processors/detector.py'> does not have the attribute 'send_new_detector_data'

tests/sentry/workflow_engine/receivers/test_project_detectors.py::TestCreatePerformanceDetectors::test_respects_default_enabled_state

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
src/sentry/testutils/helpers/features.py:230: in wrapper
    return func_or_cls(*args, **kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1421: in patched
    with self.decoration_helper(patched,
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:141: in __enter__
    return next(self.gen)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1403: in decoration_helper
    arg = exit_stack.enter_context(patching)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:530: in enter_context
    result = _enter(cm)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1495: in __enter__
    original, local = self.get_original()
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1465: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry.workflow_engine.processors.detector' from '/home/runner/work/sentry/sentry/src/sentry/workflow_engine/processors/detector.py'> does not have the attribute 'get_disabled_platforms_by_detector_type'

tests/sentry/workflow_engine/receivers/test_project_detectors.py::TestEnsureMetricDetector::test_creates_detector_with_all_components

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/receivers/test_project_detectors.py:36: in test_creates_detector_with_all_components
    with mock.patch(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1495: in __enter__
    original, local = self.get_original()
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1465: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry.workflow_engine.processors.detector' from '/home/runner/work/sentry/sentry/src/sentry/workflow_engine/processors/detector.py'> does not have the attribute 'send_new_detector_data'

tests/sentry/workflow_engine/receivers/test_project_detectors.py::TestCreateDefaultAnomalyDetector::test_creates_disabled_detector_when_plan_feature_missing

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/receivers/test_project_detectors.py:140: in test_creates_disabled_detector_when_plan_feature_missing
    with mock.patch("sentry.workflow_engine.processors.detector.send_new_detector_data"):
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1495: in __enter__
    original, local = self.get_original()
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1465: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry.workflow_engine.processors.detector' from '/home/runner/work/sentry/sentry/src/sentry/workflow_engine/processors/detector.py'> does not have the attribute 'send_new_detector_data'

tests/sentry/workflow_engine/receivers/test_project_detectors.py::TestDisableDefaultDetectorCreation::test_context_manager_disables_metric_detector_signal

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/receivers/test_project_detectors.py:200: in test_context_manager_disables_metric_detector_signal
    mock.patch("sentry.workflow_engine.processors.detector.send_new_detector_data"),
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1495: in __enter__
    original, local = self.get_original()
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1465: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry.workflow_engine.processors.detector' from '/home/runner/work/sentry/sentry/src/sentry/workflow_engine/processors/detector.py'> does not have the attribute 'send_new_detector_data'

tests/sentry/workflow_engine/receivers/test_project_detectors.py::TestCreateDefaultAnomalyDetector::test_creates_enabled_detector_when_both_features_enabled

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/receivers/test_project_detectors.py:127: in test_creates_enabled_detector_when_both_features_enabled
    with mock.patch("sentry.workflow_engine.processors.detector.send_new_detector_data"):
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1495: in __enter__
    original, local = self.get_original()
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1465: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry.workflow_engine.processors.detector' from '/home/runner/work/sentry/sentry/src/sentry/workflow_engine/processors/detector.py'> does not have the attribute 'send_new_detector_data'

tests/sentry/workflow_engine/receivers/test_project_detectors.py::TestEnsureMetricDetector::test_creates_detector_without_team

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/receivers/test_project_detectors.py:80: in test_creates_detector_without_team
    with mock.patch("sentry.workflow_engine.processors.detector.send_new_detector_data"):
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1495: in __enter__
    original, local = self.get_original()
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1465: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry.workflow_engine.processors.detector' from '/home/runner/work/sentry/sentry/src/sentry/workflow_engine/processors/detector.py'> does not have the attribute 'send_new_detector_data'

tests/sentry/workflow_engine/receivers/test_project_detectors.py::TestCreateDefaultAnomalyDetector::test_creates_detector_without_team

— log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/receivers/test_project_detectors.py:162: in test_creates_detector_without_team
    with mock.patch("sentry.workflow_engine.processors.detector.send_new_detector_data"):
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1495: in __enter__
    original, local = self.get_original()
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1465: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry.workflow_engine.processors.detector' from '/home/runner/work/sentry/sentry/src/sentry/workflow_engine/processors/detector.py'> does not have the attribute 'send_new_detector_data'

tests/sentry/workflow_engine/receivers/test_project_detectors.py::TestEnsureMetricDetector::test_returns_existing_detector_without_creating_duplicates

— log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/workflow_engine/receivers/test_project_detectors.py:105: in test_returns_existing_detector_without_creating_duplicates
    with mock.patch("sentry.workflow_engine.processors.detector.send_new_detector_data"):
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1495: in __enter__
    original, local = self.get_original()
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:1465: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry.workflow_engine.processors.detector' from '/home/runner/work/sentry/sentry/src/sentry/workflow_engine/processors/detector.py'> does not have the attribute 'send_new_detector_data'

saponifi3d added 2 commits April 3, 2026 16:23

move the code out of processors and into defaults

659d400

Move the project detector receiver into workflow_engine

0a6c43d

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 3, 2026

remove the receiver from the old init, add it to the new

0131e75

vercel bot deployed to Preview April 3, 2026 23:34 View deployment

add types for methods that were untyped

bfbaa2e

vercel bot deployed to Preview April 3, 2026 23:52 View deployment

sentry-warden bot reviewed Apr 3, 2026

View reviewed changes

src/sentry/workflow_engine/receivers/project_detectors.py Show resolved Hide resolved

re-introduce unused kwargs as Any so it passes mypy _and_ warden

87c3d8d

vercel bot deployed to Preview April 3, 2026 23:59 View deployment

saponifi3d added 2 commits April 3, 2026 17:09

Hopefully appease the mypy

81363fc

add kwargs back to the anomaly detector creation as any, hopefully ap…

a79d06c

…peases the rest of the errors

vercel bot deployed to Preview April 4, 2026 00:12 View deployment

add a type to the mock that's unused.

7e26ba7

vercel bot deployed to Preview April 4, 2026 00:18 View deployment

fix a bunch of mocks

b474df1

vercel bot deployed to Preview April 4, 2026 00:52 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ref(workflow_engine): Cleanup some of our code#112246

ref(workflow_engine): Cleanup some of our code#112246
saponifi3d wants to merge 9 commits intomasterfrom
jcallender/aci/organize-defaults-code

saponifi3d commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

saponifi3d commented Apr 3, 2026

Description

Uh oh!

github-actions bot commented Apr 3, 2026

Backend Test Failures

Uh oh!

Uh oh!

github-actions bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backend Test Failures

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Apr 4, 2026 •

edited

Loading