Conversation
Just need to rearrange the click precedence, in this case it looks like there are tooltip props that do the wrapping in the correct order, so using those.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Spread ordering overrides tooltipProps in second CompactSelect
- Reordered props to place {...triggerProps} before tooltipProps, ensuring explicit tooltip is not overridden by spread operator.
Or push these changes by commenting:
@cursor push 50f2441f2b
This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
| tooltipProps={{ | ||
| title: t('Time interval displayed in this visualization (ex. 5m)'), | ||
| }} | ||
| {...triggerProps} |
There was a problem hiding this comment.
Spread ordering overrides tooltipProps in second CompactSelect
Medium Severity
In the second CompactSelect's trigger in metricGraph/index.tsx, tooltipProps is placed before {...triggerProps}, so if triggerProps contains a tooltipProps key it will override the explicit tooltip. All three other instances in this PR correctly place tooltipProps after {...triggerProps} to ensure the tooltip isn't clobbered. This instance appears to have the order accidentally reversed, which could cause the tooltip to not display or display incorrect content.
2 participants
Summary
Just need to rearrange the click precedence, in this case it looks like there are tooltip props that do the wrapping in the correct order, so using those.
Closes DE-1007
Closes LOGS-429