feat(autofix): Redesigned empty state for autofix section#110370
feat(autofix): Redesigned empty state for autofix section#110370
Conversation
This replaces the empty state from the group summary to a CTA to start RCA.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/issueDetails/streamline/sidebar/autofixSection.tsx
Outdated
Show resolved
Hide resolved
aliu39
left a comment
aliu39
left a comment
There was a problem hiding this comment.
stamping, looks good other than the callback memo cursor comment. Also had design feedback on the Fix the Issue label
| priority="primary" | ||
| onClick={handleStartRootCause} | ||
| > | ||
| {t('Fix the Issue')} |
There was a problem hiding this comment.
Should we do something like "Start Analysis" instead? Fix the issue makes me think of solution/code changes, but this is just starting RCA right
There was a problem hiding this comment.
This i just took from the designs but this is valid feedback. I'll run it by the team before changing it
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| aspectRatio?: CSSProperties['aspectRatio']; | ||
| }>` | ||
| ${p => p.aspectRatio && `aspect-ratio: ${p.aspectRatio}`}; | ||
| `; |
There was a problem hiding this comment.
New styled() Call Violates Frontend Guidelines
Low Severity
ImageContainer is a newly added styled(Flex) call used solely to apply aspect-ratio. Per the AGENTS.md frontend guidelines, Emotion styled components should only be used in edge cases and core layout primitives like Flex should be preferred. Since aspect-ratio isn't one of the named Flex props, a style attribute on Flex directly (e.g., style={{ aspectRatio: '9 / 16' }}) or a natively supported prop could avoid creating a new styled component.
Triggered by project rule: Frontend guidelines
Zylphrex
deleted the
txiao/feat/redesigned-empty-state-for-autofix-section
branch
2 participants
This replaces the empty state from the group summary to a CTA to start RCA.