fix(tests): Fix flaky test_issue_owners_should_ratelimit#108663
Merged
fix(tests): Fix flaky test_issue_owners_should_ratelimit#108663
Conversation
…time The test uses datetime.now() for cache window_start values, and the production code uses datetime.now() to calculate cache timeouts via max(60 - elapsed, 0). In slow CI runs, elapsed time can exceed 60s, causing cache entries to expire with timeout=0, which makes the rate limit check fail to find the expected data. Freezing time ensures consistent behavior regardless of test execution speed. Fixes #108655
JoshFerge
approved these changes
Feb 20, 2026
1 task
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 24, 2026
## Summary - Fix flaky `test_issue_owners_should_ratelimit` in post_process tests - The test uses `datetime.now()` for cache window_start values, and the production code uses `datetime.now()` to calculate cache timeouts via `max(60 - elapsed, 0)`. In slow CI runs, elapsed time can exceed 60s, causing cache entries to expire immediately - Added `@freeze_time()` to ensure consistent time between cache setup and rate limit checks Fixes #108655 ## Test plan - [x] `pytest tests/sentry/tasks/test_post_process.py::PostProcessGroupErrorTest::test_issue_owners_should_ratelimit` passes
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
## Summary - Fix flaky `test_issue_owners_should_ratelimit` in post_process tests - The test uses `datetime.now()` for cache window_start values, and the production code uses `datetime.now()` to calculate cache timeouts via `max(60 - elapsed, 0)`. In slow CI runs, elapsed time can exceed 60s, causing cache entries to expire immediately - Added `@freeze_time()` to ensure consistent time between cache setup and rate limit checks Fixes #108655 ## Test plan - [x] `pytest tests/sentry/tasks/test_post_process.py::PostProcessGroupErrorTest::test_issue_owners_should_ratelimit` passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_issue_owners_should_ratelimitin post_process testsdatetime.now()for cache window_start values, and the production code usesdatetime.now()to calculate cache timeouts viamax(60 - elapsed, 0). In slow CI runs, elapsed time can exceed 60s, causing cache entries to expire immediately@freeze_time()to ensure consistent time between cache setup and rate limit checksFixes #108655
Test plan
pytest tests/sentry/tasks/test_post_process.py::PostProcessGroupErrorTest::test_issue_owners_should_ratelimitpasses