Skip to content

feat(monitors-tables): Removing hardcoded column widths#108234

Merged
Abdkhan14 merged 3 commits intomasterfrom
abdk/uptimecheckgrid
Feb 19, 2026
Merged

feat(monitors-tables): Removing hardcoded column widths#108234
Abdkhan14 merged 3 commits intomasterfrom
abdk/uptimecheckgrid

Conversation

@Abdkhan14
Copy link
Copy Markdown
Contributor

@Abdkhan14 Abdkhan14 commented Feb 13, 2026

Grideditable enforces a minwidth of 90px for the column.

Having to horizontally scroll tables should be avoided

Screenshot 2026-02-13 at 12 17 03 PM Screenshot 2026-02-13 at 12 17 15 PM Screenshot 2026-02-13 at 12 18 37 PM

After:
Screenshot 2026-02-13 at 12 25 02 PM
Screenshot 2026-02-13 at 12 25 53 PM

@Abdkhan14 Abdkhan14 requested review from a team as code owners February 13, 2026 17:26
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 13, 2026
@Abdkhan14 Abdkhan14 requested a review from jaydgoss February 13, 2026 18:34
Copy link
Copy Markdown
Member

@jaydgoss jaydgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing to double-check before merging: fit="max-content" was added to UptimeChecksGrid but not MonitorCheckInsGrid. Without it, the crons grid columns could potentially get squished below their content width in narrow containers. Worth verifying the crons table still looks right without it (or adding it there too for consistency).

Using the fixed height as a fallback

Fixes:
<img width="326" height="709" alt="Screenshot 2026-02-13 at 1 01 08 PM"
src="https://github.com/user-attachments/assets/5d3a1028-ca9f-4050-9acd-a75053d35b30"
/>

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
@Abdkhan14 Abdkhan14 merged commit 866234d into master Feb 19, 2026
62 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/uptimecheckgrid branch February 19, 2026 02:10
JonasBa pushed a commit that referenced this pull request Feb 19, 2026
Grideditable enforces a minwidth of 90px for the column. 

Having to horizontally scroll tables should be avoided 

<img width="1094" height="554" alt="Screenshot 2026-02-13 at 12 17
03 PM"
src="https://github.com/user-attachments/assets/e2e638c3-ce53-4a7e-b8f4-6c8deaae4902"
/>
<img width="1308" height="290" alt="Screenshot 2026-02-13 at 12 17
15 PM"
src="https://github.com/user-attachments/assets/cfe888bc-a715-4e11-aaf7-612b05a20d9b"
/>
<img width="276" height="708" alt="Screenshot 2026-02-13 at 12 18 37 PM"
src="https://github.com/user-attachments/assets/4e570d2d-7b27-4fdd-8e4e-1512a5216bff"
/>

After: 
<img width="1145" height="420" alt="Screenshot 2026-02-13 at 12 25
02 PM"
src="https://github.com/user-attachments/assets/2101471d-900c-426f-890b-ce6bf2360d6e"
/>
<img width="278" height="666" alt="Screenshot 2026-02-13 at 12 25 53 PM"
src="https://github.com/user-attachments/assets/b5dd4df9-b493-4c75-8751-4166d6af3d93"
/>

---------

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
mchen-sentry pushed a commit that referenced this pull request Feb 24, 2026
Grideditable enforces a minwidth of 90px for the column. 

Having to horizontally scroll tables should be avoided 

<img width="1094" height="554" alt="Screenshot 2026-02-13 at 12 17
03 PM"
src="https://github.com/user-attachments/assets/e2e638c3-ce53-4a7e-b8f4-6c8deaae4902"
/>
<img width="1308" height="290" alt="Screenshot 2026-02-13 at 12 17
15 PM"
src="https://github.com/user-attachments/assets/cfe888bc-a715-4e11-aaf7-612b05a20d9b"
/>
<img width="276" height="708" alt="Screenshot 2026-02-13 at 12 18 37 PM"
src="https://github.com/user-attachments/assets/4e570d2d-7b27-4fdd-8e4e-1512a5216bff"
/>

After: 
<img width="1145" height="420" alt="Screenshot 2026-02-13 at 12 25
02 PM"
src="https://github.com/user-attachments/assets/2101471d-900c-426f-890b-ce6bf2360d6e"
/>
<img width="278" height="666" alt="Screenshot 2026-02-13 at 12 25 53 PM"
src="https://github.com/user-attachments/assets/b5dd4df9-b493-4c75-8751-4166d6af3d93"
/>

---------

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants