feat(billing): Add emerge data categories to frontend test fixtures#106942
Merged
feat(billing): Add emerge data categories to frontend test fixtures#106942
Conversation
github-actions
bot
added
the
Scope: Frontend
github-actions
bot
added
the
Scope: Backend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Add SIZE_ANALYSIS and INSTALLABLE_BUILD category support to the SubscriptionFixture. This adds conditional MetricHistoryFixture entries for sizeAnalyses and installableBuilds when the plan includes these categories. BIL-1934
Add sizeAnalyses and installableBuilds to the default PlanFixture planCategories with Developer tier values (100 and 0 respectively). BIL-1934
Add sizeAnalyses and installableBuilds to all AM3 plan fixtures: - Added to AM3_CHECKOUT_CATEGORIES - Added display names to AM3_CATEGORY_DISPLAY_NAMES - Added planCategories entries to all 12 AM3 plans with appropriate tier values (Developer: 100/0, Team: 100/25000, Business: 100/unlimited, Enterprise/Trial: unlimited/unlimited) Update listDisplayNames test expectations to include the new categories. BIL-1934
Add sizeAnalyses and installableBuilds to all AM2 plan fixtures: - Added to AM2_CHECKOUT_CATEGORIES - Added display names to AM2_CATEGORY_DISPLAY_NAMES - Added UNLIMITED_RESERVED import - Added planCategories entries to all 13 AM2 plans with appropriate tier values BIL-1934
Add sizeAnalyses and installableBuilds to all AM1 plan fixtures: - Added to AM1_CHECKOUT_CATEGORIES - Added display names to AM1_CATEGORY_DISPLAY_NAMES - Added UNLIMITED_RESERVED import - Added planCategories entries to all 7 AM1 plans with appropriate tier values Update sortCategories and sortCategoriesWithKeys test expectations to include the new emerge categories. BIL-1934
Update test expectations and fixtures to account for new emerge categories (sizeAnalyses and installableBuilds) added in BIL-1934: - billing.spec.tsx: Update filtered category count from -2 to -4 - changePlanAction.spec.tsx: Add emerge category selections to forms - provisionSubscriptionAction.spec.tsx: Add emerge fields to API expectations All 123 tests now passing.
dashed
force-pushed
the
billing/BIL-1934
branch
from
8852757 to
aefb3ad
Compare
dashed
removed
the
Scope: Backend
mrduncan
approved these changes
Jan 26, 2026
JonasBa
pushed a commit
that referenced
this pull request
Jan 27, 2026
…106942) closes https://linear.app/getsentry/issue/BIL-1934/update-fixtures ## Summary Add SIZE_ANALYSIS (`sizeAnalyses`) and INSTALLABLE_BUILD (`installableBuilds`) emerge data categories to all frontend test fixtures. - Add emerge category support to `SubscriptionFixture` with conditional `MetricHistoryFixture` entries - Add emerge categories to default `PlanFixture` in gsApp - Update AM3 plan fixtures (12 plans) with tier-appropriate values - Update AM2 plan fixtures (13 plans) with tier-appropriate values - Update AM1 plan fixtures (7 plans) with tier-appropriate values - Update test expectations in `dataCategory.spec.tsx` **Reserved values by plan tier:** | Plan Type | sizeAnalyses | installableBuilds | |-----------|--------------|-------------------| | Developer/Free | 100 | 0 | | Team | 100 | 25,000 | | Business | 100 | unlimited | | Enterprise/Trial | unlimited | unlimited | ## Test plan - [x] TypeScript typecheck passes (`pnpm run typecheck`) - [x] All pre-commit hooks pass - [x] `dataCategory.spec.tsx` tests pass (28/28) - [x] `subscriptionPage/` tests pass (342/342)
priscilawebdev
pushed a commit
that referenced
this pull request
Feb 2, 2026
…106942) closes https://linear.app/getsentry/issue/BIL-1934/update-fixtures ## Summary Add SIZE_ANALYSIS (`sizeAnalyses`) and INSTALLABLE_BUILD (`installableBuilds`) emerge data categories to all frontend test fixtures. - Add emerge category support to `SubscriptionFixture` with conditional `MetricHistoryFixture` entries - Add emerge categories to default `PlanFixture` in gsApp - Update AM3 plan fixtures (12 plans) with tier-appropriate values - Update AM2 plan fixtures (13 plans) with tier-appropriate values - Update AM1 plan fixtures (7 plans) with tier-appropriate values - Update test expectations in `dataCategory.spec.tsx` **Reserved values by plan tier:** | Plan Type | sizeAnalyses | installableBuilds | |-----------|--------------|-------------------| | Developer/Free | 100 | 0 | | Team | 100 | 25,000 | | Business | 100 | unlimited | | Enterprise/Trial | unlimited | unlimited | ## Test plan - [x] TypeScript typecheck passes (`pnpm run typecheck`) - [x] All pre-commit hooks pass - [x] `dataCategory.spec.tsx` tests pass (28/28) - [x] `subscriptionPage/` tests pass (342/342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/getsentry/issue/BIL-1934/update-fixtures
Summary
Add SIZE_ANALYSIS (
sizeAnalyses) and INSTALLABLE_BUILD (installableBuilds) emerge data categories to all frontend test fixtures.SubscriptionFixturewith conditionalMetricHistoryFixtureentriesPlanFixturein gsAppdataCategory.spec.tsxReserved values by plan tier:
Test plan
pnpm run typecheck)dataCategory.spec.tsxtests pass (28/28)subscriptionPage/tests pass (342/342)