Skip to content

feat(seer): Add a reminder for Seer orgs who have not completed onboarding#106931

Merged
ryan953 merged 16 commits intomasterfrom
ryan953/CW-679-seer-migration-onboarding
Jan 28, 2026
Merged

feat(seer): Add a reminder for Seer orgs who have not completed onboarding#106931
ryan953 merged 16 commits intomasterfrom
ryan953/CW-679-seer-migration-onboarding

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented Jan 24, 2026

Adds a little 'reminder' widget to the sidebar, replacing the Prevent icon. The goal is to nudge people who have subscribed to Seer, and get them to configure it fully.

We only show the reminder if the org has not fully completed setup, using the same conditions that we use in the wizard (useSeerOnboardingStep).

Org has Flag Img
code-review-beta SCR-20260126-oamm
seer-added SCR-20260126-oaps
seat-based-seer-enabled SCR-20260126-oatv
mobile view SCR-20260126-obqo

If they're using legacy Seer still, then the page they land on will correspond to which data is missing

Settings Repos
SCR-20260126-olcg SCR-20260126-okzc

Fixes https://linear.app/getsentry/issue/CW-679/help-existing-seer-orgs-onboard-into-code-review-before-updating

@ryan953 ryan953 requested review from a team as code owners January 24, 2026 01:41
@linear
Copy link
Copy Markdown

linear bot commented Jan 24, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 24, 2026
@ryan953 ryan953 marked this pull request as draft January 24, 2026 01:51
<SimpleTable.Empty>
{t('No projects found matching "%(search)s"', {search})}
</div>
</SimpleTable.Empty>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this had no padding, text was on the left.

After it looks like this now:
Image


@media (min-height: 800px) {
/* TODO(ryan953): Make this shorter once showPreventNav() is removed from PrimaryNavigationItems */
@media (min-height: 724px) {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tall Borderline Small (icons hidden)
Image Image Image

Comment on lines -2440 to -2456
path: 'ai-code-review/',
children: [
{
component: make(() => import('sentry/views/prevent/preventAI/wrapper')),
children: [
{
index: true,
redirectTo: 'new/',
},
{
path: 'new/',
component: make(() => import('sentry/views/prevent/preventAI/onboarding')),
},
],
},
],
},
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed these

inlined the rest, the codecovChildren pattern is not needed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in one spot, inlined to that.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in a couple spots only. inlined to there.

@ryan953 ryan953 marked this pull request as ready for review January 27, 2026 00:45
@ryan953 ryan953 requested a review from a team as a code owner January 27, 2026 00:45
@ryan953 ryan953 changed the title WIP - seer settings for migrating orgs feat(seer): Add a reminder for Seer orgs who have not completed onboarding Jan 27, 2026
Copy link
Copy Markdown
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to dismiss the reminder?

}

const SeerButton = styled(SidebarButton)`
display: none;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is hidden?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this CSS from static/app/views/nav/primary/whatsNew/whatsNew.tsx.

It's how the sidebar works i guess, idk.
I adjusted the @media so that things stay visible for longer (stays visible when the window is shorter than before, we have fewer main nav items so there's room).

I think it'll get refactored when design eng takes ownership of the nav, which is in design stages afaik

@JonasBa
Copy link
Copy Markdown
Member

JonasBa commented Jan 28, 2026

@ryan this is just visual feedback, but could we push the button to the right side of the popover and increase the gap between the text and the button? I think that would help the flow a bit better + naturally fit with the spacing of the text

CleanShot 2026-01-28 at 10 53 08

@ryan953
Copy link
Copy Markdown
Member Author

ryan953 commented Jan 28, 2026

this is just visual feedback, but could we push the button to the right side of the popover and increase the gap between the text and the button? I think that would help the flow a bit better + naturally fit with the spacing of the text

@JonasBa done!
SCR-20260128-kana

it's also hard to adjust the width of this thing, if i could make it narrower i would. something to follow up on

@ryan953 ryan953 closed this Jan 28, 2026
@ryan953 ryan953 reopened this Jan 28, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

{tab === 'settings' ? (
<Fragment>
<SeerAutomationProjectList />
<br />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using <br /> for spacing between components

Low Severity

A <br /> element is used to add spacing between SeerAutomationProjectList and SeerAutomationDefault. This is an anti-pattern in a component-based codebase that uses a layout system with proper spacing utilities. The surrounding Stack component with gap="lg" should handle this, or a wrapper with margin/padding should be used instead.

Fix in Cursor Fix in Web

@media (min-height: 724px) {
display: flex;
}
`;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated media query breakpoint with same TODO

Low Severity

The SeerButton styled component duplicates the exact same pattern from WhatsNewButton - including the magic number 724px, the identical TODO comment about showPreventNav(), and the display: none/display: flex toggle. This breakpoint value and associated styling pattern should be extracted into a shared constant or utility to avoid maintenance burden and ensure consistent updates.

Additional Locations (1)

Fix in Cursor Fix in Web

@JonasBa
Copy link
Copy Markdown
Member

JonasBa commented Jan 28, 2026

this is just visual feedback, but could we push the button to the right side of the popover and increase the gap between the text and the button? I think that would help the flow a bit better + naturally fit with the spacing of the text

@JonasBa done! SCR-20260128-kana

it's also hard to adjust the width of this thing, if i could make it narrower i would. something to follow up on

Perfect! A narrower layout would be ideal here, ideally the width of the title or just a tad more would probably work well

@ryan953 ryan953 merged commit 8dca707 into master Jan 28, 2026
53 checks passed
@ryan953 ryan953 deleted the ryan953/CW-679-seer-migration-onboarding branch January 28, 2026 20:48
priscilawebdev pushed a commit that referenced this pull request Feb 2, 2026
…rding (#106931)

Adds a little 'reminder' widget to the sidebar, replacing the Prevent
icon. The goal is to nudge people who have subscribed to Seer, and get
them to configure it fully.

We only show the reminder if the org has not fully completed setup,
using the same conditions that we use in the wizard
(`useSeerOnboardingStep`).

| Org has Flag | Img |
| --- | --- |
| `code-review-beta` | <img width="468" height="182"
alt="SCR-20260126-oamm"
src="https://github.com/user-attachments/assets/b28d95ba-e438-4d37-94a3-b33e8ef46e80"
/>
| `seer-added` | <img width="473" height="185" alt="SCR-20260126-oaps"
src="https://github.com/user-attachments/assets/17295abe-90c0-43c0-9dbc-79a9747b1c5c"
/>
| `seat-based-seer-enabled` | <img width="469" height="194"
alt="SCR-20260126-oatv"
src="https://github.com/user-attachments/assets/ec0009b8-dd25-4b2e-af54-2281b14fe276"
/>
| mobile view | <img width="442" height="785" alt="SCR-20260126-obqo"
src="https://github.com/user-attachments/assets/f965fff2-3a21-44fe-834a-84bc1c22a015"
/>

If they're using legacy Seer still, then the page they land on will
correspond to which data is missing
| Settings | Repos |
| --- | --- |
| <img width="1320" height="950" alt="SCR-20260126-olcg"
src="https://github.com/user-attachments/assets/eacae6a2-ceac-4b96-8cc1-129f7276fbed"
/> | <img width="1320" height="950" alt="SCR-20260126-okzc"
src="https://github.com/user-attachments/assets/f3ec662b-bf80-47cd-be61-a3c3602ce779"
/>



Fixes
https://linear.app/getsentry/issue/CW-679/help-existing-seer-orgs-onboard-into-code-review-before-updating
ryan953 added a commit that referenced this pull request Feb 3, 2026
…tegration (#107288)

For other integrations, like BitBucket and GitLab, we dont want to send
a reminder because these things should be as setup as possible already.
The extra steps are github only right now (but coming soon to more
SCMs!)

Followup of: #106931
Fixes CW-720
jaydgoss pushed a commit that referenced this pull request Feb 12, 2026
…tegration (#107288)

For other integrations, like BitBucket and GitLab, we dont want to send
a reminder because these things should be as setup as possible already.
The extra steps are github only right now (but coming soon to more
SCMs!)

Followup of: #106931
Fixes CW-720
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants