feat(seer): Add a reminder for Seer orgs who have not completed onboarding#106931
feat(seer): Add a reminder for Seer orgs who have not completed onboarding#106931
Conversation
| <SimpleTable.Empty> | ||
| {t('No projects found matching "%(search)s"', {search})} | ||
| </div> | ||
| </SimpleTable.Empty> |
c5d07a6 to
e537ff1
Compare
…iew beta. we show the tip if theyre not done onboarding
|
|
||
| @media (min-height: 800px) { | ||
| /* TODO(ryan953): Make this shorter once showPreventNav() is removed from PrimaryNavigationItems */ | ||
| @media (min-height: 724px) { |
| path: 'ai-code-review/', | ||
| children: [ | ||
| { | ||
| component: make(() => import('sentry/views/prevent/preventAI/wrapper')), | ||
| children: [ | ||
| { | ||
| index: true, | ||
| redirectTo: 'new/', | ||
| }, | ||
| { | ||
| path: 'new/', | ||
| component: make(() => import('sentry/views/prevent/preventAI/onboarding')), | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
removed these
inlined the rest, the codecovChildren pattern is not needed.
There was a problem hiding this comment.
used in one spot, inlined to that.
There was a problem hiding this comment.
used in a couple spots only. inlined to there.
static/gsApp/views/seerAutomation/components/seerAutomationProjectList.tsx
Show resolved
Hide resolved
billyvg
left a comment
There was a problem hiding this comment.
Is there no way to dismiss the reminder?
| } | ||
|
|
||
| const SeerButton = styled(SidebarButton)` | ||
| display: none; |
There was a problem hiding this comment.
I pulled this CSS from static/app/views/nav/primary/whatsNew/whatsNew.tsx.
It's how the sidebar works i guess, idk.
I adjusted the @media so that things stay visible for longer (stays visible when the window is shorter than before, we have fewer main nav items so there's room).
I think it'll get refactored when design eng takes ownership of the nav, which is in design stages afaik
static/gsApp/views/seerAutomation/components/seerAutomationProjectList.tsx
Show resolved
Hide resolved
|
@ryan this is just visual feedback, but could we push the button to the right side of the popover and increase the gap between the text and the button? I think that would help the flow a bit better + naturally fit with the spacing of the text
|
@JonasBa done! it's also hard to adjust the width of this thing, if i could make it narrower i would. something to follow up on |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| {tab === 'settings' ? ( | ||
| <Fragment> | ||
| <SeerAutomationProjectList /> | ||
| <br /> |
There was a problem hiding this comment.
Using <br /> for spacing between components
Low Severity
A <br /> element is used to add spacing between SeerAutomationProjectList and SeerAutomationDefault. This is an anti-pattern in a component-based codebase that uses a layout system with proper spacing utilities. The surrounding Stack component with gap="lg" should handle this, or a wrapper with margin/padding should be used instead.
| @media (min-height: 724px) { | ||
| display: flex; | ||
| } | ||
| `; |
There was a problem hiding this comment.
Duplicated media query breakpoint with same TODO
Low Severity
The SeerButton styled component duplicates the exact same pattern from WhatsNewButton - including the magic number 724px, the identical TODO comment about showPreventNav(), and the display: none/display: flex toggle. This breakpoint value and associated styling pattern should be extracted into a shared constant or utility to avoid maintenance burden and ensure consistent updates.
Additional Locations (1)
Perfect! A narrower layout would be ideal here, ideally the width of the title or just a tad more would probably work well |
…rding (#106931) Adds a little 'reminder' widget to the sidebar, replacing the Prevent icon. The goal is to nudge people who have subscribed to Seer, and get them to configure it fully. We only show the reminder if the org has not fully completed setup, using the same conditions that we use in the wizard (`useSeerOnboardingStep`). | Org has Flag | Img | | --- | --- | | `code-review-beta` | <img width="468" height="182" alt="SCR-20260126-oamm" src="https://github.com/user-attachments/assets/b28d95ba-e438-4d37-94a3-b33e8ef46e80" /> | `seer-added` | <img width="473" height="185" alt="SCR-20260126-oaps" src="https://github.com/user-attachments/assets/17295abe-90c0-43c0-9dbc-79a9747b1c5c" /> | `seat-based-seer-enabled` | <img width="469" height="194" alt="SCR-20260126-oatv" src="https://github.com/user-attachments/assets/ec0009b8-dd25-4b2e-af54-2281b14fe276" /> | mobile view | <img width="442" height="785" alt="SCR-20260126-obqo" src="https://github.com/user-attachments/assets/f965fff2-3a21-44fe-834a-84bc1c22a015" /> If they're using legacy Seer still, then the page they land on will correspond to which data is missing | Settings | Repos | | --- | --- | | <img width="1320" height="950" alt="SCR-20260126-olcg" src="https://github.com/user-attachments/assets/eacae6a2-ceac-4b96-8cc1-129f7276fbed" /> | <img width="1320" height="950" alt="SCR-20260126-okzc" src="https://github.com/user-attachments/assets/f3ec662b-bf80-47cd-be61-a3c3602ce779" /> Fixes https://linear.app/getsentry/issue/CW-679/help-existing-seer-orgs-onboard-into-code-review-before-updating







Adds a little 'reminder' widget to the sidebar, replacing the Prevent icon. The goal is to nudge people who have subscribed to Seer, and get them to configure it fully.
We only show the reminder if the org has not fully completed setup, using the same conditions that we use in the wizard (
useSeerOnboardingStep).code-review-betaseer-addedseat-based-seer-enabledIf they're using legacy Seer still, then the page they land on will correspond to which data is missing
Fixes https://linear.app/getsentry/issue/CW-679/help-existing-seer-orgs-onboard-into-code-review-before-updating