Skip to content

feat(aci): Add inline alert creation inside monitor form#105765

Merged
malwilley merged 5 commits intomasterfrom
malwilley/feat/aci-inline-alert-creation
Jan 7, 2026
Merged

feat(aci): Add inline alert creation inside monitor form#105765
malwilley merged 5 commits intomasterfrom
malwilley/feat/aci-inline-alert-creation

Conversation

@malwilley
Copy link
Copy Markdown
Member

This adds a new "Create Alert" drawer with a similar, slightly stripped down alert creation form. This allows users to quickly create a new alert for their monitor without being taken out of the experience.

Summary of changes:

  • Extracting out common form elements so they can be used in both form components
  • Adds the new AutomationBuilderDrawerForm component
  • Updates the "Alert" section of the monitor form to use the new design and the "create alert" flow
CleanShot.2026-01-06.at.14.41.34.mp4

@malwilley malwilley requested a review from a team as a code owner January 6, 2026 23:15
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 6, 2026
onClick={toggleDrawer}
>
{t('Connect an Alert')}
</Button>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ref on Edit Alerts button breaks drawer toggle

Medium Severity

The ref is only attached to the "Connect Existing Alerts" button in the empty state (line 114), but the "Edit Alerts" button in the non-empty state (line 93) also uses toggleDrawer. When alerts exist, ref.current is null, causing shouldCloseOnInteractOutside to always return true. This can cause a race condition where clicking "Edit Alerts" while the drawer is open triggers both the close-on-interact-outside behavior and the onClick toggle, potentially causing the drawer to close then immediately reopen.

Additional Locations (1)

Fix in Cursor Fix in Web

source: 'drawer',
success: false,
});
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing error message leaves loading indicator stuck on failure

Medium Severity

When createAutomation fails in the catch block, addLoadingMessage was called earlier but no corresponding addErrorMessage is called to replace it. The import on line 5 only includes addLoadingMessage and addSuccessMessage, not addErrorMessage. This leaves the "Creating Alert..." loading indicator visible indefinitely after a failure, with no error feedback shown to the user.

Fix in Cursor Fix in Web

@malwilley malwilley merged commit f38122e into master Jan 7, 2026
52 checks passed
@malwilley malwilley deleted the malwilley/feat/aci-inline-alert-creation branch January 7, 2026 16:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants