Merged
Conversation
Skip three flaky tests that are failing in CI due to non-deterministic set ordering when encoding tag_keys as arrays: - tests/sentry/eventstream/test_item_helpers.py::test_encode_attributes_with_tags - tests/sentry/discover/test_dashboard_widget_split.py::test_unhandled_filter_sets_error_events_dataset - tests/sentry/discover/test_dataset_split.py::test_unhandled_filter_sets_error_events_dataset These tests fail with different tag orderings across runs because sets are unordered in Python. Skipping to unblock CI while investigating fix. Related: #105124
Member
Author
|
might be from #105074? |
JoshFerge
changed the title
armcknight
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are failing intermittently in CI
Test run failures
Tests that are flaking:
tests/sentry/eventstream/test_item_helpers.py::test_encode_attributes_with_tagstests/sentry/discover/test_dashboard_widget_split.py::test_unhandled_filter_sets_error_events_datasettests/sentry/discover/test_dataset_split.py::test_unhandled_filter_sets_error_events_dataset