Conversation
github-actions
bot
added
the
Scope: Backend
chromy
changed the title
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
chromy
force-pushed
the
chromy/2025-12-09-issues-v2-part05
branch
from
65ccf9d to
24968f9
Compare
|
|
||
| id = uuid4().hex | ||
| event_id = uuid4().hex | ||
| fingerprint = uuid4().hex |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
chromy
force-pushed
the
chromy/2025-12-09-issues-v2-part05
branch
from
24968f9 to
0ea0ddf
Compare
runningcode
left a comment
runningcode
left a comment
There was a problem hiding this comment.
Looks good! just had two questions
| event_data = { | ||
| "event_id": event_id, | ||
| "project_id": project_id, | ||
| "platform": "other", |
There was a problem hiding this comment.
should platform be something like ios/android?
There was a problem hiding this comment.
Yeah I think so but I'm not 100% on what platform is for here - so I want to get Richard's opinion on it. Will leave for now and follow up.
| occurrence=occurrence, | ||
| event_data=event_data, | ||
| ) | ||
| issue_count += 1 |
There was a problem hiding this comment.
so the install_delta and download delta being higher than the threshold are two separate issues? why is that? isn't the cause the same?
There was a problem hiding this comment.
Good point, I think the idea is one group per cause - so I think having two occurrences for regressions is fine - but might be that the fingerprint should be the same for both issues (so they get grouped together). I'll think the best way is to test it out and see what feels right.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104953 +/- ##
===========================================
+ Coverage 79.38% 80.44% +1.05%
===========================================
Files 9386 9390 +4
Lines 402943 403422 +479
Branches 25915 25915
===========================================
+ Hits 319883 324537 +4654
+ Misses 82612 78437 -4175
Partials 448 448 |
2 participants
This adds V0 of preprod size issues to Sentry.
The logic is behind a feature flag (
organizations:preprod-issues)In this initial version: