fix(seer): Don't override when bulk updating settings#104918
Merged
fix(seer): Don't override when bulk updating settings#104918
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104918 +/- ##
===========================================
- Coverage 80.52% 80.41% -0.12%
===========================================
Files 9398 9393 -5
Lines 405707 403397 -2310
Branches 25923 25923
===========================================
- Hits 326711 324387 -2324
- Misses 78556 78570 +14
Partials 440 440 |
ryan953
added a commit
that referenced
this pull request
Dec 16, 2025
…ings (#104912) Followup to #104908 Depends on #104918 Currently the backend expects that all fields will be passed to the bulk-edit endpoint, but that's only true in the wizard context, when we're creating everything for the first time: https://github.com/getsentry/sentry/blob/master/src/sentry/integrations/api/endpoints/organization_repository_settings.py#L16-L41 On the settings page people can bulk-update fields, one field at a time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup: #104912
Previously we were requiring both
enabledCodeReviewandcodeReviewTriggerswhen bulk updating. Here we allow either or both, and don't override if a field isn't present.