Skip to content

fix(ui): Button's label clipped#104849

Merged
priscilawebdev merged 1 commit intomasterfrom
priscila/fix/ui-button-label-clipped
Dec 12, 2025
Merged

fix(ui): Button's label clipped#104849
priscilawebdev merged 1 commit intomasterfrom
priscila/fix/ui-button-label-clipped

Conversation

@priscilawebdev
Copy link
Copy Markdown
Member

Button label text clipping was introduced by PR #104384 (UI2 merge) which combined with the existing height: 100% on ButtonLabel, forced the label to match the button's full height and constrained text within a tight lineHeight: 1rem, cutting off descenders on letters like g, j, p, q, y.

Before
image

After

image

@priscilawebdev priscilawebdev requested a review from a team as a code owner December 12, 2025 11:03
@priscilawebdev priscilawebdev requested a review from a team December 12, 2025 11:03
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 12, 2025
@priscilawebdev priscilawebdev enabled auto-merge (squash) December 12, 2025 12:24
Copy link
Copy Markdown
Member

@shellmayr shellmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@priscilawebdev priscilawebdev merged commit 853a7ce into master Dec 12, 2025
49 checks passed
@priscilawebdev priscilawebdev deleted the priscila/fix/ui-button-label-clipped branch December 12, 2025 12:28
JonasBa added a commit that referenced this pull request Dec 15, 2025
JonasBa added a commit that referenced this pull request Dec 15, 2025
The root cause of the issue was addressed in
#104976 so this change should be
reverted as it is causing the layout to be cutoff on the help button
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants