feat(occurrences): Add rollout utils#104841
Merged
thetruecpaul merged 1 commit intomasterfrom Dec 12, 2025
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
We want to control how reads from Occurrences on EAP happen. Generally, we want it to look like: * We roll out ingestion to some % of a region * (Optional pause to wait for some data) * We roll out double-read to the region * The snuba & EAP results will start different — because EAP doesn't have full retention for the full region yet — but should track to zero differences over time. Then, for each new read we onboard: * Gate reading at all behind the standard rollout * Gate using the data behind the callsite allowlist * Set up a reasonable_match comparator * Land PR. * Observe data for callsite. * Should have 100% reasonable_match rate. * Should have exact_match rate go to 100% over time. * Once exact_match has been at 100% for some time, add callsite to allowlist.
thetruecpaul
force-pushed
the
cpaul/eap/add-rollout-utils
branch
from
2c32a1c to
81da48e
Compare
cvxluo
approved these changes
Dec 12, 2025
Comment on lines
+8
to
+9
| def should_double_read_from_eap() -> bool: | ||
| return options.get("eap.occurrences.should_double_read") |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| def should_double_read_from_eap() -> bool: | |
| return options.get("eap.occurrences.should_double_read") |
i think the option name is explanatory
Contributor
Author
There was a problem hiding this comment.
I'd just prefer to centralize the rollout in case we want to do something smarter (e.g. have a callsite-level blocklist) in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to control how reads from Occurrences on EAP happen. Generally, we want it to look like:
Then, for each new read we onboard: