Skip to content

fix(aci): set action config values to null instead of '' or undefined#104796

Merged
ameliahsu merged 3 commits intomasterfrom
mia/aci/fix-ticketing-and-webhooks
Dec 12, 2025
Merged

fix(aci): set action config values to null instead of '' or undefined#104796
ameliahsu merged 3 commits intomasterfrom
mia/aci/fix-ticketing-and-webhooks

Conversation

@ameliahsu
Copy link
Copy Markdown
Contributor

The Action validators were failing because the Action configs expect null for nonexistent values, not ''.

Additionally, when stripping Actions of their targetDisplay, we were previously removing the field from the config, but to keep typing consistent we should be setting targetDisplay: null

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 11, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104796      +/-   ##
===========================================
- Coverage   80.48%    80.48%   -0.01%     
===========================================
  Files        9359      9359              
  Lines      401722    401720       -2     
  Branches    25822     25821       -1     
===========================================
- Hits       323326    323324       -2     
  Misses      77954     77954              
  Partials      442       442              

@ameliahsu ameliahsu marked this pull request as ready for review December 12, 2025 14:39
@ameliahsu ameliahsu requested a review from a team as a code owner December 12, 2025 14:39
@ameliahsu ameliahsu merged commit 05f13fb into master Dec 12, 2025
49 checks passed
@ameliahsu ameliahsu deleted the mia/aci/fix-ticketing-and-webhooks branch December 12, 2025 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants