fix(aci): set action config values to null instead of '' or undefined#104796
Merged
fix(aci): set action config values to null instead of '' or undefined#104796
null instead of '' or undefined#104796Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104796 +/- ##
===========================================
- Coverage 80.48% 80.48% -0.01%
===========================================
Files 9359 9359
Lines 401722 401720 -2
Branches 25822 25821 -1
===========================================
- Hits 323326 323324 -2
Misses 77954 77954
Partials 442 442 |
malwilley
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Action validators were failing because the Action configs expect
nullfor nonexistent values, not''.Additionally, when stripping Actions of their
targetDisplay, we were previously removing the field from the config, but to keep typing consistent we should be settingtargetDisplay: null