fix(seer settings): Fallback to code mappings if seer preferences don't exist

[Mihir-Mavalankar]

PR Details

• The migration function will use code mappings now as a fallback if seer preferences don't exist for a project.
• Also small change to use ObjectStatus.ACTIVE to get active projects.

[roaga]

what are you doing in case there is no existing_pref in the first place?

[Mihir-Mavalankar]

what are you doing in case there is no existing_pref in the first place?

We will set the preferences with repositories set to []. Assuming code mapping does not exist too.

[roaga]

what are you doing in case there is no existing_pref in the first place?

We will set the preferences with repositories set to []. Assuming code mapping does not exist too.

isn't the whole point of the discussion to fallback to code mappings in this case too?

[Mihir-Mavalankar]

what are you doing in case there is no existing_pref in the first place?

We will set the preferences with repositories set to []. Assuming code mapping does not exist too.

isn't the whole point of the discussion to fallback to code mappings in this case too?

Yes we are falling back. That's this PR. I am calling get_autofix_repos_from_project_code_mappings here as a fallback.

[roaga]

what are you doing in case there is no existing_pref in the first place?

We will set the preferences with repositories set to []. Assuming code mapping does not exist too.

isn't the whole point of the discussion to fallback to code mappings in this case too?

Yes we are falling back. That's this PR. I am calling get_autofix_repos_from_project_code_mappings here as a fallback.

but you're only doing it if there is an existing pref and the repos are empty

repositories = existing_pref.get("repositories")
if not repositories:
            repositories = get_autofix_repos_from_project_code_mappings(projects_by_id[project_id])

The case that matters to us is instead if there is no existing pref at all

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #104795    +/-   ##
=========================================
  Coverage   80.47%    80.48%            
=========================================
  Files        9363      9363            
  Lines      401849    401986   +137     
  Branches    25833     25833            
=========================================
+ Hits       323389    323524   +135     
- Misses      78018     78020     +2     
  Partials      442       442            

[roaga]

a test might be nice as this gets more complicated