Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
Member
|
cc @narsaynorath you were just talking about this bug! |
JonasBa
approved these changes
Dec 11, 2025
Member
JonasBa
left a comment
JonasBa
left a comment
There was a problem hiding this comment.
My one note is that the current naming implies an overflow only use-case, however the actual implementation seems generic enough to where it could be used for other use-cases.
Collaborator
Author
|
renamed to |
# Conflicts: # static/app/components/core/compactSelect/compactSelect.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an
OverflowBoundaryContext, exposed fromscraps, which consumers can use to limit the size of dropdown menus (currently only forcompactSelect). Per default, the menu can grow to accommodate its largest option, but it’s limited by the size of the<main>section.In some cases, parent contains might want to further limit the width, e.g. for sidebars, drawers. The first consumer is the
SlideOverPanelto fix a bug in dashboards. @gggritso FYI