fix(infra): Fix test_dual_write test pollution causing flakes#104741
Merged
fix(infra): Fix test_dual_write test pollution causing flakes#104741
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104741 +/- ##
===========================================
- Coverage 80.60% 80.48% -0.12%
===========================================
Files 9356 9351 -5
Lines 403999 401700 -2299
Branches 25813 25813
===========================================
- Hits 325638 323305 -2333
- Misses 77919 77953 +34
Partials 442 442 |
hubertdeng123
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes the new #1 offending flaky test found with

shuffle-tests,test_dual_write.The underlying issue was a mutation of global state that would only be hit when
test_dual_write__min_zerowas ran beforetest_dual_write. This fixes this with a proper copy/mutationRepro'd and confirmed fixed with