Skip to content

fix(explorer): just use clickable links and fix wobble#104709

Merged
roaga merged 5 commits intomasterfrom
explorer/fix-wobble-and-nav
Dec 11, 2025
Merged

fix(explorer): just use clickable links and fix wobble#104709
roaga merged 5 commits intomasterfrom
explorer/fix-wobble-and-nav

Conversation

@roaga
Copy link
Copy Markdown
Contributor

@roaga roaga commented Dec 10, 2025

replace navigation buttons with clickable links. Keyboard support is maintained
Screenshot 2025-12-10 at 4 06 30 PM

Also fixes bug where blocks wobble with some styling changes

@roaga roaga requested a review from aliu39 December 10, 2025 20:24
@roaga roaga requested a review from a team as a code owner December 10, 2025 20:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 10, 2025
@JoshFerge JoshFerge requested a review from a team December 10, 2025 22:04
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12834 1 12833 10
View the top 1 failed test(s) by shortest run time
BlockComponent Focus State shows reset button when isFocused=true
Stack Traces | 0.048s run time
TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "Restart conversation from here"

Here are the accessible roles:

  img:

  Name "":
  ...

  --------------------------------------------------
  button:

  Name "↩":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../views/seerExplorer/blockComponents.spec.tsx:94:16)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@roaga roaga merged commit cf1d2de into master Dec 11, 2025
49 checks passed
@roaga roaga deleted the explorer/fix-wobble-and-nav branch December 11, 2025 00:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants