fix(detectors): Render list _after_ visualisation#104681
Merged
evanpurkhiser merged 1 commit intomasterfrom Dec 10, 2025
Merged
fix(detectors): Render list _after_ visualisation#104681evanpurkhiser merged 1 commit intomasterfrom
evanpurkhiser merged 1 commit intomasterfrom
Conversation
As it is right now, rendering the PositionedGridLineOverlay at the end of the list causes the `:last-child` to incorrectly target the grid line overlay, instead of the last row in the list. Before <img alt="clipboard.png" width="276" src="https://i.imgur.com/GYzGhwI.png" /> After <img alt="clipboard.png" width="260" src="https://i.imgur.com/enV0I1H.png" />
github-actions
bot
added
the
Scope: Frontend
malwilley
approved these changes
Dec 10, 2025
evanpurkhiser
deleted the
evanpurkhiser/fix-detectors-render-list-after-visualisation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it is right now, rendering the PositionedGridLineOverlay at the end
of the list causes the
:last-childto incorrectly target the grid lineoverlay, instead of the last row in the list.
Before
After