ref(ai-insights): switch to gen_ai.operation.name/type#104673
ref(ai-insights): switch to gen_ai.operation.name/type#104673obostjancic merged 12 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Bug: MCP span attributes never shown after op removal
The op parameter was removed from all getHighlightedSpanAttributes call sites, but the function still uses op?.startsWith('mcp.') to detect MCP spans and display their highlighted attributes (tool name, resource URI, prompt name, transport). Since op is never passed, MCP spans will no longer show these attributes in the trace drawer, breaking existing MCP functionality that still uses span.op based detection.
static/app/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/description.tsx#L283-L287
static/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/description.tsx#L200-L204
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/sections/highlights.tsx#L90-L94
Bug: MCP span attributes never shown after op removal
The op parameter was removed from all getHighlightedSpanAttributes call sites, but the function still uses op?.startsWith('mcp.') to detect MCP spans and display their highlighted attributes (tool name, resource URI, prompt name, transport). Since op is never passed, MCP spans will no longer show these attributes in the trace drawer, breaking existing MCP functionality that still uses span.op based detection.
static/app/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/description.tsx#L283-L287
static/app/views/performance/newTraceDetails/traceDrawer/details/span/sections/description.tsx#L200-L204
static/app/views/performance/newTraceDetails/traceDrawer/details/transaction/sections/highlights.tsx#L90-L94
static/app/views/performance/newTraceDetails/traceDrawer/details/highlightedAttributes.tsx
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceDrawer/details/highlightedAttributes.spec.tsx
Show resolved
Hide resolved
Co-authored-by: ArthurKnaus <arthur.knaus@sentry.io>
Co-authored-by: ArthurKnaus <arthur.knaus@sentry.io>
Co-authored-by: ArthurKnaus <arthur.knaus@sentry.io>
static/app/views/performance/newTraceDetails/traceDrawer/details/highlightedAttributes.tsx
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104673 +/- ##
========================================
Coverage 80.53% 80.53%
========================================
Files 9334 9334
Lines 401102 401063 -39
Branches 25743 25735 -8
========================================
- Hits 323008 322990 -18
+ Misses 77652 77631 -21
Partials 442 442 |
Migrated AI span detection from
span.opbased matching (e.g.,span.op:gen_ai.*,span.op:gen_ai.invoke_agent) to usegen_ai.operation.typeandgen_ai.operation.nameattributes .