fix(infra): Fix span convert test pollution#104661
Merged
Conversation
hubertdeng123
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes the third largest test offender for causing
shuffle-teststo break,test_convert_span_to_item. This failure was caused by an improper copy/modification ofSPAN_KAFKA_MESSAGE. This modification affected tests that ran after, an in cases wheretest_convert_span_to_itemran aftertest_convert_renamed_attribute_meta, it would fail due to_meta.attributesbeing improperly modified by the earlier tests.This fix now properly copies the
SPAN_KAFKA_MESSAGEfor testing. Confirmed fixed with a repro that failed before this fix: