Skip to content

fix(infra): Fix span convert test pollution#104661

Merged
rbro112 merged 1 commit intomasterfrom
ryan/fix_span_convert_test_pollution
Dec 10, 2025
Merged

fix(infra): Fix span convert test pollution#104661
rbro112 merged 1 commit intomasterfrom
ryan/fix_span_convert_test_pollution

Conversation

@rbro112
Copy link
Copy Markdown
Member

@rbro112 rbro112 commented Dec 10, 2025

Fixes the third largest test offender for causing shuffle-tests to break, test_convert_span_to_item. This failure was caused by an improper copy/modification of SPAN_KAFKA_MESSAGE. This modification affected tests that ran after, an in cases where test_convert_span_to_item ran after test_convert_renamed_attribute_meta, it would fail due to _meta.attributes being improperly modified by the earlier tests.

This fix now properly copies the SPAN_KAFKA_MESSAGE for testing. Confirmed fixed with a repro that failed before this fix:

 pytest tests/sentry/spans/consumers/process_segments/test_convert.py::test_convert_renamed_attribute_meta tests/sentry/spans/consumers/process_segments/test_convert.py::test_convert_span_to_item

@rbro112 rbro112 requested review from a team as code owners December 10, 2025 00:28
Copy link
Copy Markdown
Member Author

rbro112 commented Dec 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rbro112 rbro112 changed the title Fix span convert test pollution fix(infra): Fix span convert test pollution Dec 10, 2025
@rbro112 rbro112 merged commit 1beb96f into master Dec 10, 2025
96 of 98 checks passed
@rbro112 rbro112 deleted the ryan/fix_span_convert_test_pollution branch December 10, 2025 01:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants