feat(ui): Convert Feature component to FC#104659
Merged
Conversation
not removing the HoC for now
github-actions
bot
added
the
Scope: Frontend
billyvg
approved these changes
Dec 10, 2025
Comment on lines
+121
to
+126
| const shouldMatchOnlyProject = feature.match(/^projects:(.+)/); | ||
| if (shouldMatchOnlyProject) { | ||
| return projectFeatures.includes(shouldMatchOnlyProject[1]!); | ||
| } | ||
|
|
||
| const shouldMatchOnlyOrg = feature.match(/^organizations:(.+)/); |
Member
There was a problem hiding this comment.
Would test() be better since we don't use the matches?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not removing the HoC for now since org prop is being abused to pass in custom orgs in tests