Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| onClick={handleClick} | ||
| to={to} | ||
| aria-label={t('Create Alert')} | ||
| aria-label={createButtonLabel} |
Contributor
There was a problem hiding this comment.
Bug: Prop spread order causes aria-label to be overridden
In CreateAlertFromViewButton, the aria-label is set to createButtonLabel but then ...buttonProps is spread afterward. Since callers like those in static/app/views/discover/savedQuery/index.tsx and static/app/views/performance/transactionSummary/header.tsx explicitly pass aria-label={t('Create Alert')}, this will override the computed label. When workflow-engine-ui is enabled, the button should display "Create Monitor" but the caller's explicit "Create Alert" aria-label will take precedence. The ...buttonProps spread needs to come before the explicit aria-label prop, or the aria-label should be filtered out of buttonProps.
ameliahsu
approved these changes
Dec 10, 2025
malwilley
deleted the
malwilley/fix/update-create-alert-buttons-to-reference-monitors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few different areas that refer to "Create an Alert" instead of "Create a Monitor"