Skip to content

chore(ACI): Remove GA'd metric issue flags#104652

Merged
ceorourke merged 2 commits intomasterfrom
ceorourke-rm-gad-metric-issue-flags
Dec 9, 2025
Merged

chore(ACI): Remove GA'd metric issue flags#104652
ceorourke merged 2 commits intomasterfrom
ceorourke-rm-gad-metric-issue-flags

Conversation

@ceorourke
Copy link
Copy Markdown
Member

Remove metric issue flags that have been GA'd and set to a default of true for a while. Do not merge until https://github.com/getsentry/sentry-options-automator/pull/5919 is merged.

@ceorourke ceorourke requested a review from a team December 9, 2025 23:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 9, 2025
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Removed feature flag still referenced in test

The feature flag organizations:workflow-engine-single-process-metric-issues is being removed from the registry, but it's still referenced in tests/sentry/incidents/test_charts.py at line 184 via @with_feature("organizations:workflow-engine-single-process-metric-issues"). When this test runs, the Feature context manager will raise a ValueError with "Unregistered feature flag" because features.get() will throw FeatureNotRegistered for the now-unregistered flag. The test file needs to be updated to remove this decorator.

src/sentry/features/temporary.py#L542-L543

# Enable dual writing for issue alert issues (see: alerts create issues)
manager.add("organizations:workflow-engine-issue-alert-dual-write", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False, default=True)

Fix in Cursor Fix in Web


@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #104652   +/-   ##
========================================
  Coverage   80.51%    80.52%           
========================================
  Files        9329      9329           
  Lines      400842    400897   +55     
  Branches    25705     25705           
========================================
+ Hits       322756    322822   +66     
+ Misses      77620     77609   -11     
  Partials      466       466           

@ceorourke ceorourke merged commit 19d0d5c into master Dec 9, 2025
66 checks passed
@ceorourke ceorourke deleted the ceorourke-rm-gad-metric-issue-flags branch December 9, 2025 23:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants