chore(ACI): Remove GA'd metric issue flags#104652
Conversation
There was a problem hiding this comment.
Bug: Removed feature flag still referenced in test
The feature flag organizations:workflow-engine-single-process-metric-issues is being removed from the registry, but it's still referenced in tests/sentry/incidents/test_charts.py at line 184 via @with_feature("organizations:workflow-engine-single-process-metric-issues"). When this test runs, the Feature context manager will raise a ValueError with "Unregistered feature flag" because features.get() will throw FeatureNotRegistered for the now-unregistered flag. The test file needs to be updated to remove this decorator.
src/sentry/features/temporary.py#L542-L543
sentry/src/sentry/features/temporary.py
Lines 542 to 543 in 2f08b76
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104652 +/- ##
========================================
Coverage 80.51% 80.52%
========================================
Files 9329 9329
Lines 400842 400897 +55
Branches 25705 25705
========================================
+ Hits 322756 322822 +66
+ Misses 77620 77609 -11
Partials 466 466 |
Remove metric issue flags that have been GA'd and set to a default of true for a while. Do not merge until https://github.com/getsentry/sentry-options-automator/pull/5919 is merged.