Skip to content

chore(aci): New feature flag for opting out of redirects#104646

Merged
malwilley merged 1 commit intomasterfrom
malwilley/chore/new-feature-flag-for-opting-out-of-redirects
Dec 10, 2025
Merged

chore(aci): New feature flag for opting out of redirects#104646
malwilley merged 1 commit intomasterfrom
malwilley/chore/new-feature-flag-for-opting-out-of-redirects

Conversation

@malwilley
Copy link
Copy Markdown
Member

We check for isStaff to allow us to test internally, but a feature flag will allow us to toggle off and verify that the redirects work correctly.

@malwilley malwilley requested a review from a team December 9, 2025 22:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 9, 2025
# Enable new workflow_engine UI (see: alerts create issues)
manager.add("organizations:workflow-engine-ui", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Disable redirects from alert rules to the new workflow_engine UI
manager.add("organizations:workflow-engine-redirect-opt-out", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than having this be opt-out and True, could we have this be opt-in? The negation of the boolean expression can add to a bit of confusion, so naming this to be positive case for true will help the readability.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought an opt out would be better so that we can enable this internally then forget about it. If it's an opt-in then we will have trouble rolling it out along with workflow-engine-ui

@malwilley malwilley requested a review from saponifi3d December 9, 2025 23:57
@malwilley malwilley merged commit 51b875f into master Dec 10, 2025
67 checks passed
@malwilley malwilley deleted the malwilley/chore/new-feature-flag-for-opting-out-of-redirects branch December 10, 2025 00:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants