chore(aci): New feature flag for opting out of redirects#104646
Merged
chore(aci): New feature flag for opting out of redirects#104646
Conversation
saponifi3d
reviewed
Dec 9, 2025
| # Enable new workflow_engine UI (see: alerts create issues) | ||
| manager.add("organizations:workflow-engine-ui", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) | ||
| # Disable redirects from alert rules to the new workflow_engine UI | ||
| manager.add("organizations:workflow-engine-redirect-opt-out", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) |
Contributor
There was a problem hiding this comment.
rather than having this be opt-out and True, could we have this be opt-in? The negation of the boolean expression can add to a bit of confusion, so naming this to be positive case for true will help the readability.
Member
Author
There was a problem hiding this comment.
I thought an opt out would be better so that we can enable this internally then forget about it. If it's an opt-in then we will have trouble rolling it out along with workflow-engine-ui
saponifi3d
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We check for
isStaffto allow us to test internally, but a feature flag will allow us to toggle off and verify that the redirects work correctly.