fix(np): Remove frozen dataclass due to task/dict behavior#104643
Merged
Christinarlong merged 2 commits intomasterfrom Dec 10, 2025
Merged
fix(np): Remove frozen dataclass due to task/dict behavior#104643Christinarlong merged 2 commits intomasterfrom
Christinarlong merged 2 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
leeandher
approved these changes
Dec 10, 2025
Member
leeandher
left a comment
leeandher
left a comment
There was a problem hiding this comment.
damn thats quite the bug, how did you find this?? 👏
Contributor
Author
Thankfully there was a sentry error ;-;, our issues noise is quite bad tho so it was annoying to find |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change isn't ideal but removing the immutability is the simplest way to fix this issue. When going from service -> notify_task_async task boundary the notification data gets turned to a dict that doesn't include the source attribute because it's a field that wasn't instantiated in that data instance.
Also removes some misc logging