Skip to content

feat(seer): Allow users to add more repos in RCA onboarding step#104626

Merged
billyvg merged 3 commits intomasterfrom
billy/cw-25-rca-step-add-ability-to-add-repos
Dec 10, 2025
Merged

feat(seer): Allow users to add more repos in RCA onboarding step#104626
billyvg merged 3 commits intomasterfrom
billy/cw-25-rca-step-add-ability-to-add-repos

Conversation

@billyvg
Copy link
Copy Markdown
Member

@billyvg billyvg commented Dec 9, 2025

This allows the user to add a repository when they are on the RCA onboarding step. The repos selected in Code Review step may not always be the same as RCA.

@linear
Copy link
Copy Markdown

linear bot commented Dec 9, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 9, 2025
This allows the user to add a repository when they are on the RCA onboarding step. The repos selected in Code Review step may not always be the same as RCA.
@billyvg billyvg force-pushed the billy/cw-25-rca-step-add-ability-to-add-repos branch from 7117e58 to b73a2a9 Compare December 10, 2025 15:27
@billyvg billyvg changed the title feat(seer): Change repo to be a Select dropdown feat(seer): Allow users to add more repos in RCA onboarding step Dec 10, 2025
@billyvg
Copy link
Copy Markdown
Member Author

billyvg commented Dec 10, 2025

@sentry review

Comment on lines 184 to 188
.map(([repoId, projects]) => {
// Don't overwrite existing mappings
if (prev[repoId]) {
// Don't overwrite existing mappings that have projects
if (prev[repoId] && prev[repoId].length > 0) {
return null;
}

This comment was marked as outdated.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended -- it's fine to load/overwrite mappings when there are no projects mapped. If you remove projects from a mapping, you should either remove the repo row.

This was changed for the case when we add a new repo row and want to check and load code mappings.

@billyvg billyvg marked this pull request as ready for review December 10, 2025 20:26
@billyvg billyvg requested review from a team and ryan953 December 10, 2025 20:26
@billyvg billyvg merged commit 40a83e1 into master Dec 10, 2025
47 checks passed
@billyvg billyvg deleted the billy/cw-25-rca-step-add-ability-to-add-repos branch December 10, 2025 22:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants