Skip to content

fix(spans-migration): commit changes once everything passes#104580

Merged
nikkikapadia merged 1 commit intomasterfrom
nikki/fix/alerts-migration-errors
Dec 9, 2025
Merged

fix(spans-migration): commit changes once everything passes#104580
nikkikapadia merged 1 commit intomasterfrom
nikki/fix/alerts-migration-errors

Conversation

@nikkikapadia
Copy link
Copy Markdown
Member

made a bunch of changes to the alerts migration scripts to make sure it works the way we want to

  1. Ensure that on translation and rollback that all the changes in the db get made only after all actions are successful
  2. For all count(...) functions with parameters, we're going to default them to the regular count so they get translated properly
  3. Some functions get translated with the equation| prefix because we needed that in dashboards and explore but it's not needed for alerts so I've stripped out the equation prefix for these functions
  4. Added a BUNCH of logs so that we know where things are failing if they fail during the migration

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 9, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/sentry/explore/translation/alerts_translation.py 80.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104580      +/-   ##
===========================================
+ Coverage   80.53%    80.54%   +0.01%     
===========================================
  Files        9349      9350       +1     
  Lines      399992    400519     +527     
  Branches    25646     25646              
===========================================
+ Hits       322117    322582     +465     
- Misses      77427     77489      +62     
  Partials      448       448              

@nikkikapadia nikkikapadia marked this pull request as ready for review December 9, 2025 19:26
@nikkikapadia nikkikapadia merged commit b2d06fc into master Dec 9, 2025
68 checks passed
@nikkikapadia nikkikapadia deleted the nikki/fix/alerts-migration-errors branch December 9, 2025 21:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants