Conversation
When converting the reference epoch timestamp to iso strings, make sure we round the timestamps appropriately. Start timestamps should be rounded down and end timestamps should be rounded up so that we don't miss any samples due to bad rounding. One example of this is if we have 2 samples in a chunk, and the end timestamp is rounded down, the 2nd sample is then lost.
github-actions
bot
added
the
Scope: Frontend
Dav1dde
approved these changes
Dec 8, 2025
nsdeschenes
approved these changes
Dec 8, 2025
Zylphrex
deleted the
txiao/fix/round-continuous-profile-timestamps-appropriately
branch
ryan953
pushed a commit
that referenced
this pull request
Dec 9, 2025
…04541) When converting the reference epoch timestamp to iso strings, make sure we round the timestamps appropriately. Start timestamps should be rounded down and end timestamps should be rounded up so that we don't miss any samples due to bad rounding. One example of this is if we have 2 samples in a chunk, and the end timestamp is rounded down, the 2nd sample is then lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting the reference epoch timestamp to iso strings, make sure we round the timestamps appropriately. Start timestamps should be rounded down and end timestamps should be rounded up so that we don't miss any samples due to bad rounding.
One example of this is if we have 2 samples in a chunk, and the end timestamp is rounded down, the 2nd sample is then lost.