Skip to content

ref(scraps): use new typography tokens#104470

Merged
natemoo-re merged 10 commits intomasterfrom
scraps/nm/migrate-typography
Dec 12, 2025
Merged

ref(scraps): use new typography tokens#104470
natemoo-re merged 10 commits intomasterfrom
scraps/nm/migrate-typography

Conversation

@natemoo-re
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re commented Dec 5, 2025

Stacked PR on top of #104468. This PR migrates our existing core components to use the new typography tokens. Components outside of core will be handled in a follow-up, as there are a lot of changes to make.

For ease of review, I recommend reviewing by commit rather than as a whole.

  • 1a227b6 migrates to theme.font.size.*
  • ea1c234 migrates to theme.font.lineHeight.*
  • c10a577 migrates to theme.font.family.*
  • 2a4466b migrates to theme.font.weight.medium
  • 80047b8 migrates to theme.font.weight.regular

Fixes DE-605, DE-311, DE-312, DE-316

@natemoo-re natemoo-re requested a review from a team as a code owner December 5, 2025 19:59
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 5, 2025
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasBa
Copy link
Copy Markdown
Member

JonasBa commented Dec 9, 2025

Hawkeye @TkDodo :)

@JonasBa
Copy link
Copy Markdown
Member

JonasBa commented Dec 9, 2025

Fixes DE-605

@linear
Copy link
Copy Markdown

linear bot commented Dec 9, 2025

@natemoo-re
Copy link
Copy Markdown
Member Author

natemoo-re commented Dec 12, 2025

Removing DE-311, DE-312, DE-316 since this only covers core components. These still need to be fully removed from the rest of the codebase and from the theme.

@natemoo-re natemoo-re force-pushed the scraps/nm/apply-typography branch from c190215 to 54007cc Compare December 12, 2025 16:20
@natemoo-re natemoo-re force-pushed the scraps/nm/migrate-typography branch from 80047b8 to 11b916d Compare December 12, 2025 16:39
@natemoo-re natemoo-re force-pushed the scraps/nm/apply-typography branch from 54007cc to aa23e6a Compare December 12, 2025 18:13
Base automatically changed from scraps/nm/apply-typography to master December 12, 2025 18:27
@natemoo-re natemoo-re enabled auto-merge (squash) December 12, 2025 18:30
@natemoo-re natemoo-re merged commit 75e7993 into master Dec 12, 2025
48 checks passed
@natemoo-re natemoo-re deleted the scraps/nm/migrate-typography branch December 12, 2025 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants