chore(search): Use fuzzy search on raw text values with spaces by nsdeschenes · Pull Request #104405 · getsentry/sentry

nsdeschenes · 2025-12-04T19:05:52Z

This PR tweaks the replacement logic in useQueryBuilderState to handle unquoted values with spaces slightly differently. Instead of using the contains operator we will instead do a fuzzy search on the value:
i.e. test value -> *test * value*

This PR also conditionally adds the message filter key as the auto replace key for the logs search bar based off of the search-query-builder-raw-search-replacement flag.

Ticket: LOGS-521

codecov · 2025-12-04T19:12:25Z

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
12802	3	12799	10

View the top 3 failed test(s) by shortest run time

replaceFreeTextTokens when there are free text tokens when there is already a replace token present with a different operator

Stack Traces | 0.006s run time

Error: expect(received).toBe(expected) // Object.is equality

Expected: "span.description:test span.description:Contains\"other value\""
Received: "span.description:test span.description:\"*other * value*\""
    at toBe (.../searchQueryBuilder/hooks/useQueryBuilderState.spec.tsx:200:32)
    at Object.<anonymous> (.../sentry/node_modules/.pnpm/jest-each@30.0..../jest-each/build/index.js:80:140)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

replaceFreeTextTokens when there are free text tokens when there is already a replace token present with a space

Stack Traces | 0.007s run time

Error: expect(received).toBe(expected) // Object.is equality

Expected: "span.description:Containstest span.description:Contains\"other value\""
Received: "span.description:Containstest span.description:\"*other * value*\""
    at toBe (.../searchQueryBuilder/hooks/useQueryBuilderState.spec.tsx:200:32)
    at Object.<anonymous> (.../sentry/node_modules/.pnpm/jest-each@30.0..../jest-each/build/index.js:80:140)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

replaceFreeTextTokens when there are free text tokens when there is one free text token that has a space

Stack Traces | 0.028s run time

Error: expect(received).toBe(expected) // Object.is equality

Expected: "span.description:Contains\"test test\""
Received: "span.description:\"*test * test*\""
    at toBe (.../searchQueryBuilder/hooks/useQueryBuilderState.spec.tsx:200:32)
    at Object.<anonymous> (.../sentry/node_modules/.pnpm/jest-each@30.0..../jest-each/build/index.js:80:140)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

…ontain spaces

…h keys

static/app/components/searchQueryBuilder/hooks/useQueryBuilderState.tsx

nikkikapadia

lgtm

🚧 Initial poking around

ad17c77

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 4, 2025

vercel bot deployed to Preview December 4, 2025 19:08 View deployment

nsdeschenes added 3 commits December 5, 2025 07:41

👔 Update query builder state to do fuzzy wildcards with values that c…

b144fb4

…ontain spaces

✅ Update tests

d408481

👔 Update useLogsSearchQueryBuilder props to include replace raw searc…

2a033b6

…h keys

vercel bot deployed to Preview December 5, 2025 11:46 View deployment

nsdeschenes marked this pull request as ready for review December 5, 2025 11:56

nsdeschenes requested a review from a team as a code owner December 5, 2025 11:56

cursor bot reviewed Dec 5, 2025

View reviewed changes

static/app/components/searchQueryBuilder/hooks/useQueryBuilderState.tsx Outdated Show resolved Hide resolved

nsdeschenes added 2 commits December 5, 2025 08:05

👔 Keep default logic if asterisk is present

b45f7a0

✅ Add in new test

06d30e7

sentry bot reviewed Dec 5, 2025

View reviewed changes

static/app/components/searchQueryBuilder/hooks/useQueryBuilderState.tsx Show resolved Hide resolved

vercel bot deployed to Preview December 5, 2025 12:09 View deployment

alexjillard reviewed Dec 5, 2025

View reviewed changes

static/app/components/searchQueryBuilder/hooks/useQueryBuilderState.tsx Outdated Show resolved Hide resolved

nsdeschenes added 2 commits December 5, 2025 10:11

👔 Handle multiple spaces and remove extra spaces in value

fcd83c9

✅ Add and update tests

f940321

vercel bot deployed to Preview December 5, 2025 14:14 View deployment

nikkikapadia approved these changes Dec 10, 2025

View reviewed changes

nsdeschenes merged commit d745c01 into master Dec 10, 2025
48 checks passed

nsdeschenes deleted the nd/chore-search-fuzzy-search-on-spaced-values branch December 10, 2025 16:51

github-actions bot locked and limited conversation to collaborators Dec 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(search): Use fuzzy search on raw text values with spaces#104405

chore(search): Use fuzzy search on raw text values with spaces#104405
nsdeschenes merged 8 commits intomasterfrom
nd/chore-search-fuzzy-search-on-spaced-values

nsdeschenes commented Dec 4, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikkikapadia left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nsdeschenes commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 4, 2025

❌ 3 Tests Failed:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nikkikapadia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nsdeschenes commented Dec 4, 2025 •

edited

Loading