chore(aci): add alert creation + success analytics#104403
Conversation
github-actions
bot
added
the
Scope: Frontend
| 'cron_monitor.created': { | ||
| cron_schedule_type: MonitorConfig['schedule_type']; | ||
| }; | ||
| 'issue_alert_rule.created': Record<string, unknown>; |
There was a problem hiding this comment.
I couldn't figure out another typing solution for issue_alert_rule.created where there aren't additional parameters
There was a problem hiding this comment.
Yeah I think this should be the correct way
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104403 +/- ##
========================================
Coverage 80.59% 80.59%
========================================
Files 9343 9343
Lines 399417 399412 -5
Branches 25589 25589
========================================
- Hits 321896 321892 -4
+ Misses 77061 77060 -1
Partials 460 460 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return; | ||
| } | ||
|
|
||
| const payload = formDataToEndpointPayload(data as TFormData); |
There was a problem hiding this comment.
Bug: Payload creation moved outside try-catch loses error handling
The formDataToEndpointPayload call was moved from inside the try-catch block to outside it. Previously, if this function threw an exception, it would be caught and the error handling code would run (addErrorMessage, onError callback, onSubmitError). Now if it throws, the exception propagates uncaught, bypassing all error handling and potentially crashing the UI without user feedback.
Adding analytics for creating old alert rules, cron monitors, and uptime monitors in the old UI so that we can compare these numbers to the new UI. Also added a `success: boolean` field to the monitor/automation creation analytics so we can see if the new UI is intuitive or if users are running into lots of errors.
2 participants
Adding analytics for creating old alert rules, cron monitors, and uptime monitors in the old UI so that we can compare these numbers to the new UI. Also added a
success: booleanfield to the monitor/automation creation analytics so we can see if the new UI is intuitive or if users are running into lots of errors.