Skip to content

fix(dashboards): add padding and autoresizing text in details widget#104393

Merged
DominikB2014 merged 1 commit intomasterfrom
dominikbuszowiecki/browse-85-spans-widgets-use-timeseriesvisualization
Dec 4, 2025
Merged

fix(dashboards): add padding and autoresizing text in details widget#104393
DominikB2014 merged 1 commit intomasterfrom
dominikbuszowiecki/browse-85-spans-widgets-use-timeseriesvisualization

Conversation

@DominikB2014
Copy link
Copy Markdown
Contributor

@DominikB2014 DominikB2014 commented Dec 4, 2025

Adds padding and auto resizing text for non database spans (because database spans have their own renderer). Most of the styling is taken from the existing big number widget

Before After
image image

@DominikB2014 DominikB2014 requested a review from a team as a code owner December 4, 2025 16:05
@linear
Copy link
Copy Markdown

linear bot commented Dec 4, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 4, 2025
line-height: 1;
text-align: left !important;
}
`;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing white-space:nowrap for AutoSizedText single-line requirement

The AutoSizedText component is designed for single-line text only (as noted in its documentation). The new AutoResizeParent styled component is missing white-space: nowrap styling, which means long span descriptions could wrap to multiple lines. This breaks the auto-sizing algorithm since it relies on measuring a single line of text. The similar implementation in bigNumberWidgetVisualization.tsx correctly uses NumberContainerOverride with white-space: nowrap for this purpose.

Fix in Cursor Fix in Web

@DominikB2014 DominikB2014 merged commit 65fdb79 into master Dec 4, 2025
53 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-85-spans-widgets-use-timeseriesvisualization branch December 4, 2025 16:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants