Skip to content

fix(ui): fallback selector for compactSelect boundary#104388

Merged
TkDodo merged 1 commit intomasterfrom
tkdodo/fix/select-boundary-fallback
Dec 5, 2025
Merged

fix(ui): fallback selector for compactSelect boundary#104388
TkDodo merged 1 commit intomasterfrom
tkdodo/fix/select-boundary-fallback

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Dec 4, 2025

not all pages have a main section, but most have a div with id="main", which we can query as a fallback

but most have a div with id="main", which we can query as a fallback
@TkDodo TkDodo marked this pull request as ready for review December 4, 2025 13:12
@TkDodo TkDodo requested a review from a team as a code owner December 4, 2025 13:12
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 4, 2025
@TkDodo TkDodo merged commit 6041467 into master Dec 5, 2025
50 checks passed
@TkDodo TkDodo deleted the tkdodo/fix/select-boundary-fallback branch December 5, 2025 15:16
ryan953 pushed a commit that referenced this pull request Dec 9, 2025
not all pages have a `main` section, but most have a div with id="main",
which we can query as a fallback
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants