fix(aci): Extend taint tracking to delayed workflow condition evaluation#104368
Merged
fix(aci): Extend taint tracking to delayed workflow condition evaluation#104368
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104368 +/- ##
===========================================
+ Coverage 72.09% 80.40% +8.30%
===========================================
Files 9388 9393 +5
Lines 403214 403531 +317
Branches 25991 25991
===========================================
+ Hits 290699 324458 +33759
+ Misses 112067 78625 -33442
Partials 448 448 |
wedamija
approved these changes
Dec 10, 2025
| groups_to_fire[group_id].add(dcg) | ||
|
|
||
| return groups_to_fire | ||
| return groups_to_fire, _ConditionEvaluationStats(tainted=tainted, untainted=untainted) |
Member
There was a problem hiding this comment.
Nit: Wondering if we should just report the stats in here instead of returning them
kcons
force-pushed
the
kcons/more_prec
branch
from
458524d to
702708e
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delayed_workflow can fail to evaluate snuba queries and as a result potentially trigger incorrectly.
We already report this case, but only locally and without any reasonable way to assess the impact.
Extending the TriggerResult taint-tracking approach to delayed workflow condition evaluation allows us to start
tracking at least in terms of if-condition evaluations how many results are tainted vs not, giving us something much more user-relevant to alert on.
This should be refined further to be reported in terms of workflows and/or actions, but that's a follow-up.
Updates ACI-563.