fix(Replay): Normalize Project ID Typing To Int For Frontend#104358
Merged
cliffordxing merged 1 commit intomasterfrom Dec 4, 2025
Merged
fix(Replay): Normalize Project ID Typing To Int For Frontend#104358cliffordxing merged 1 commit intomasterfrom
cliffordxing merged 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104358 +/- ##
============================================
+ Coverage 66.03% 80.57% +14.54%
============================================
Files 9338 9347 +9
Lines 399132 399699 +567
Branches 25599 25599
============================================
+ Hits 263550 322067 +58517
+ Misses 135129 77179 -57950
Partials 453 453 |
srest2021
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EAP returns
agg_project_idcolumn as a float, which we eventually convert to a string inpost_process.py:Since
agg_project_idis a float, the conversion to a string results in a ".0" trailling the ID, which results in an unknown project when passed to the frontend.After asserting that the
agg_project_idis indeed a float, this PR updates the normalization function to also convert theagg_project_idto an int first (to truncate the decimals) to account for the above issue.Relates to: https://linear.app/getsentry/issue/REPLAY-824/create-query-function-for-replay-details